Bug 104550 – [Qt] MediaPlayerQTKit broken after switching QPainter to raster engine.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zeno Albisser]

[Qt] MediaPlayerQTKit broken after switching QPainter to raster engine.

[Zeno Albisser]

Created attachment 178539 [details]
Patch

[Simon Hausmann]

Comment on attachment 178539 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178539&action=review

r=me with comments/changes.

Looking forward to this code path disappearing altogether hopefully in the near future ;-)

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1374
> +    NSBitmapImageRep *imageRep = [[NSBitmapImageRep alloc] initWithBitmapDataPlanes: NULL

I think you're going to need to call [imageRep release] later on after painting to release the memory again, no?

[Zeno Albisser]

(In reply to comment #2)
> Looking forward to this code path disappearing altogether hopefully in the near future ;-)
Me too.

> > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1374
> > +    NSBitmapImageRep *imageRep = [[NSBitmapImageRep alloc] initWithBitmapDataPlanes: NULL
> 
> I think you're going to need to call [imageRep release] later on after painting to release the memory again, no?
Yes.

[Zeno Albisser]

Committed r137159: <http://trac.webkit.org/changeset/137159>

[Balazs Kelemen]

Just a quick note on this patch: probably we want to introduce a global (WTF) helper for bgr <-> rgb conversion, since it is subject of SIMD and I believe Gabor Rapcsányi already implemented it in NEON at some other place :)

[Simon Hausmann]

(In reply to comment #5)
> Just a quick note on this patch: probably we want to introduce a global (WTF) helper for bgr <-> rgb conversion, since it is subject of SIMD and I believe Gabor Rapcsányi already implemented it in NEON at some other place :)

Maybe yes, but we're going to stop using the code here very soon, so that's going to be one user less.

[Gabor Rapcsanyi]

(In reply to comment #5)
> Just a quick note on this patch: probably we want to introduce a global (WTF) helper for bgr <-> rgb conversion, since it is subject of SIMD and I believe Gabor Rapcsányi already implemented it in NEON at some other place :)

I had a patch to speed up a little bit this conversion:
https://bugs.webkit.org/show_bug.cgi?id=103630

With NEON SIMD it could be twice as fast as now, if you are interested in I can make a bug for it.