WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104546
Web Inspector: remove the Overrides / Settings context menu from gear icon
https://bugs.webkit.org/show_bug.cgi?id=104546
Summary
Web Inspector: remove the Overrides / Settings context menu from gear icon
Pavel Feldman
Reported
2012-12-10 06:19:58 PST
It sounds like too many people don't like the way it works. Bringing things back: overrides will be a tab in settings for now.
Attachments
Patch
(8.99 KB, patch)
2012-12-10 06:30 PST
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Patch
(9.04 KB, patch)
2012-12-10 06:51 PST
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Patch
(8.60 KB, patch)
2012-12-10 06:55 PST
,
Pavel Feldman
apavlov
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-12-10 06:30:11 PST
Created
attachment 178535
[details]
Patch
Pavel Feldman
Comment 2
2012-12-10 06:51:40 PST
Created
attachment 178540
[details]
Patch
Pavel Feldman
Comment 3
2012-12-10 06:55:55 PST
Created
attachment 178541
[details]
Patch
Alexander Pavlov (apavlov)
Comment 4
2012-12-10 06:57:10 PST
Comment on
attachment 178541
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=178541&action=review
> Source/WebCore/inspector/front-end/SettingsScreen.js:428 > +}
Do you want to add this.containerElement = this._view.containerElement; here for safety?
Pavel Feldman
Comment 5
2012-12-10 07:21:48 PST
Committed
r137154
: <
http://trac.webkit.org/changeset/137154
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug