Bug 104544 - [WK2] TiledBackingStore: remove unneeded 'treatAsInitialValue' parameter from PageViewportControllerClient::setContentsScale
Summary: [WK2] TiledBackingStore: remove unneeded 'treatAsInitialValue' parameter from...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-10 06:07 PST by Mikhail Pozdnyakov
Modified: 2012-12-10 06:59 PST (History)
8 users (show)

See Also:

Attachments
patch (5.98 KB, patch)
2012-12-10 06:13 PST, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-12-10 06:07:39 PST 
The 'treatAsInitialValue' parameter in PageViewportControllerClient::setContentsScale() is not used by anyone. Can be dropped to make the code cleaner.
Comment 1 Mikhail Pozdnyakov 2012-12-10 06:13:02 PST 
Created attachment 178530 [details]
patch
Comment 2 Andras Becsi 2012-12-10 06:23:33 PST 
Note that on Qt we might actually need to pass that flag through the delayed setting of the scale, since this information is lost which resulted in bugs in the double-tap-to-zoom logic: see https://bugs.webkit.org/show_bug.cgi?id=103889.

But we can also add a separate function to clean the scale stack if needed, so I'm not opposing this clean-up.
Comment 3 WebKit Review Bot 2012-12-10 06:59:50 PST 
Comment on attachment 178530 [details]
patch

Clearing flags on attachment: 178530

Committed r137149: <http://trac.webkit.org/changeset/137149>
Comment 4 WebKit Review Bot 2012-12-10 06:59:55 PST 
All reviewed patches have been landed.  Closing bug.