RESOLVED FIXED 104544
[WK2] TiledBackingStore: remove unneeded 'treatAsInitialValue' parameter from PageViewportControllerClient::setContentsScale 
https://bugs.webkit.org/show_bug.cgi?id=104544
Summary [WK2] TiledBackingStore: remove unneeded 'treatAsInitialValue' parameter from...
Mikhail Pozdnyakov
Reported 2012-12-10 06:07:39 PST
The 'treatAsInitialValue' parameter in PageViewportControllerClient::setContentsScale() is not used by anyone. Can be dropped to make the code cleaner.
Attachments
patch (5.98 KB, patch)
2012-12-10 06:13 PST, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-12-10 06:13:02 PST
Created attachment 178530 [details] patch
Andras Becsi
Comment 2 2012-12-10 06:23:33 PST
Note that on Qt we might actually need to pass that flag through the delayed setting of the scale, since this information is lost which resulted in bugs in the double-tap-to-zoom logic: see https://bugs.webkit.org/show_bug.cgi?id=103889. But we can also add a separate function to clean the scale stack if needed, so I'm not opposing this clean-up.
WebKit Review Bot
Comment 3 2012-12-10 06:59:50 PST
Comment on attachment 178530 [details] patch Clearing flags on attachment: 178530 Committed r137149: <http://trac.webkit.org/changeset/137149>
WebKit Review Bot
Comment 4 2012-12-10 06:59:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.