Bug 104527 - [GTK] Build GObject DOM bindings as a separate library
: [GTK] Build GObject DOM bindings as a separate library
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-10 02:20 PST by Carlos Garcia Campos
Modified: 2012-12-10 09:56 PST (History)
7 users (show)

See Also:


Attachments
Patch (27.89 KB, patch)
2012-12-10 02:26 PST, Carlos Garcia Campos
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-12-10 02:20:26 PST
And make independent from webkitgtk lib.
Comment 1 Carlos Garcia Campos 2012-12-10 02:26:09 PST
Created attachment 178496 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-10 02:27:34 PST
Attachment 178496 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/gobject/WebKitDOMBinding.h:29:  Missing spaces around |  [whitespace/operators] [3]
Source/WebCore/bindings/gobject/WebKitDOMBinding.h:30:  Missing spaces around |  [whitespace/operators] [3]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Xan Lopez 2012-12-10 03:38:49 PST
Comment on attachment 178496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178496&action=review

Let's poke Martin about sharing those bits among the various libraries.

> Source/WebCore/bindings/gobject/WebKitDOMBinding.h:33
>  namespace WebCore {

As we had said I think it could make sense to put this thing somewhere for WebKit1 and WebKit2 to share like we do with other stuff, that way we can avoid duplications.

> Source/WebCore/bindings/scripts/gobject-generate-headers.pl:80
> +

And same with this?
Comment 4 Martin Robinson 2012-12-10 03:44:17 PST
Comment on attachment 178496 [details]
Patch

Looks good to me!
Comment 5 Carlos Garcia Campos 2012-12-10 04:30:56 PST
Comment on attachment 178496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178496&action=review

>> Source/WebCore/bindings/gobject/WebKitDOMBinding.h:33
>>  namespace WebCore {
> 
> As we had said I think it could make sense to put this thing somewhere for WebKit1 and WebKit2 to share like we do with other stuff, that way we can avoid duplications.

Yes it can be moved to a common place, but it's just 3 defines, not sure it's worth it.

>> Source/WebCore/bindings/scripts/gobject-generate-headers.pl:80
>> +
> 
> And same with this?

Ditto.
Comment 6 Xan Lopez 2012-12-10 09:44:31 PST
Comment on attachment 178496 [details]
Patch

OK, let's break the build/tests.
Comment 7 Carlos Garcia Campos 2012-12-10 09:56:13 PST
Committed r137173: <http://trac.webkit.org/changeset/137173>