And make independent from webkitgtk lib.
Created attachment 178496 [details] Patch
Attachment 178496 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/gobject/WebKitDOMBinding.h:29: Missing spaces around | [whitespace/operators] [3] Source/WebCore/bindings/gobject/WebKitDOMBinding.h:30: Missing spaces around | [whitespace/operators] [3] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 178496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178496&action=review Let's poke Martin about sharing those bits among the various libraries. > Source/WebCore/bindings/gobject/WebKitDOMBinding.h:33 > namespace WebCore { As we had said I think it could make sense to put this thing somewhere for WebKit1 and WebKit2 to share like we do with other stuff, that way we can avoid duplications. > Source/WebCore/bindings/scripts/gobject-generate-headers.pl:80 > + And same with this?
Comment on attachment 178496 [details] Patch Looks good to me!
Comment on attachment 178496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178496&action=review >> Source/WebCore/bindings/gobject/WebKitDOMBinding.h:33 >> namespace WebCore { > > As we had said I think it could make sense to put this thing somewhere for WebKit1 and WebKit2 to share like we do with other stuff, that way we can avoid duplications. Yes it can be moved to a common place, but it's just 3 defines, not sure it's worth it. >> Source/WebCore/bindings/scripts/gobject-generate-headers.pl:80 >> + > > And same with this? Ditto.
Comment on attachment 178496 [details] Patch OK, let's break the build/tests.
Committed r137173: <http://trac.webkit.org/changeset/137173>