Bug 104516 - [Shadow DOM][Refactoring] HTMLContentElement,HTMLShadowElement::m_registeredWithShadowRoot should be moved to InsertionPoint
Summary: [Shadow DOM][Refactoring] HTMLContentElement,HTMLShadowElement::m_registeredW...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 103339
  Show dependency tree / graph
 
Reported: 2012-12-10 00:05 PST by Hajime Morrita
Modified: 2012-12-10 19:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (15.81 KB, patch)
2012-12-10 01:39 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch for landing (15.78 KB, patch)
2012-12-10 16:58 PST, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-12-10 00:05:02 PST 
There are apparent code duplication. We can pull them up to the super class.
Comment 1 Hajime Morrita 2012-12-10 01:39:37 PST 
Created attachment 178490 [details]
Patch
Comment 2 Hajime Morrita 2012-12-10 01:40:36 PST 
This is a step forward to hide <content> and <shadow> behind the flag.
Comment 3 WebKit Review Bot 2012-12-10 01:42:39 PST 
Attachment 178490 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/html/shadow/ContentDistributor.cpp:115:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/html/shadow/ContentDistributor.cpp:131:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dimitri Glazkov (Google) 2012-12-10 10:25:00 PST 
Comment on attachment 178490 [details]
Patch

Style elf is angry with you.
Comment 5 Hajime Morrita 2012-12-10 16:58:41 PST 
Created attachment 178668 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-12-10 17:43:16 PST 
Comment on attachment 178668 [details]
Patch for landing

Clearing flags on attachment: 178668

Committed r137233: <http://trac.webkit.org/changeset/137233>
Comment 7 WebKit Review Bot 2012-12-10 17:43:19 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Jessie Berlin 2012-12-10 19:14:00 PST 
Note: build fix is in http://trac.webkit.org/changeset/137240