Bug 104507 - Factor node traversal into standalone functions
Summary: Factor node traversal into standalone functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-09 22:06 PST by Antti Koivisto
Modified: 2012-12-10 16:43 PST (History)
33 users (show)

See Also:

Attachments
patch (149.19 KB, patch)
2012-12-09 22:31 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch2 (139.51 KB, patch)
2012-12-09 22:48 PST, Antti Koivisto 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch3 (142.10 KB, patch)
2012-12-10 10:08 PST, Antti Koivisto 		eric: review+
Details | Formatted Diff | Diff
patch4 (142.15 KB, patch)
2012-12-10 10:39 PST, Antti Koivisto 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
patch5 (142.71 KB, patch)
2012-12-10 15:44 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-12-09 22:06:35 PST 
Node traversal functions are currently Node and ContainerNode members. Their implementations are scattered over multiple header and source files. These functions have no particular reason to be members as they don't require non-public access. Make them freestanding function instead and gather them together.
Comment 1 Antti Koivisto 2012-12-09 22:31:33 PST 
Created attachment 178474 [details]
patch
Comment 2 Antti Koivisto 2012-12-09 22:48:01 PST 
Created attachment 178477 [details]
patch2
Comment 3 WebKit Review Bot 2012-12-09 23:20:24 PST 
Comment on attachment 178477 [details]
patch2

Attachment 178477 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15219827
Comment 4 Peter Beverloo (cr-android ews) 2012-12-09 23:40:41 PST 
Comment on attachment 178477 [details]
patch2

Attachment 178477 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15230463
Comment 5 kov's GTK+ EWS bot 2012-12-10 00:52:44 PST 
Comment on attachment 178477 [details]
patch2

Attachment 178477 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15238361
Comment 6 EFL EWS Bot 2012-12-10 01:05:05 PST 
Comment on attachment 178477 [details]
patch2

Attachment 178477 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15249002
Comment 7 EFL EWS Bot 2012-12-10 01:11:52 PST 
Comment on attachment 178477 [details]
patch2

Attachment 178477 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15242176
Comment 8 Antti Koivisto 2012-12-10 10:08:46 PST 
Created attachment 178582 [details]
patch3
Comment 9 Eric Seidel (no email) 2012-12-10 10:13:59 PST 
Comment on attachment 178582 [details]
patch3

Seems like a great idea.  Thank you. :)
Comment 10 Dimitri Glazkov (Google) 2012-12-10 10:17:46 PST 
Morrita-san, this is relevant to work you're doing on bug 104332.
Comment 11 Antti Koivisto 2012-12-10 10:39:50 PST 
Created attachment 178586 [details]
patch4
Comment 12 EFL EWS Bot 2012-12-10 13:12:36 PST 
Comment on attachment 178586 [details]
patch4

Attachment 178586 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/15227785
Comment 13 Antti Koivisto 2012-12-10 15:44:26 PST 
Created attachment 178654 [details]
patch5

Based on Darin's suggestion renamed nextSibling -> nextSkippingChildren
Comment 14 Antti Koivisto 2012-12-10 16:14:45 PST 
http://trac.webkit.org/changeset/137221
Comment 15 Hajime Morrita 2012-12-10 16:43:51 PST 
(In reply to comment #10)
> Morrita-san, this is relevant to work you're doing on bug 104332.
Yeah, I'm thinking about something like NodeRenderingTraversal for encapsulte
enabling/disabling ShadowComposedTreeWalker.