Bug 104498 – [EFL][WK2] Enable TEXT_AUTOSIZING

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Jaehun Lim]

Enable TEXT_AUTOSIZING feature.

[Divakar]

Created attachment 208239 [details]
Patch

[Divakar]

Added patch for enabling TEXT_AUTOSIZING feature on EFL port.

[Jaehun Lim]

(In reply to comment #2)
> Added patch for enabling TEXT_AUTOSIZING feature on EFL port.

You have to edit Tools/Scripts/webkitperl/FeatureList.pm. Please see http://trac.webkit.org/wiki/AddingFeatures.

And you have to resolve the HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP warning issue, too. http://trac.webkit.org/browser/trunk/Source/WebCore/page/Settings.cpp#L131.

[Divakar]

Created attachment 208320 [details]
Patch

[Divakar]

Updated the patch.
I did not find any warning related to HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP

[EFL EWS Bot]

Comment on attachment 208320 [details]
Patch

Attachment 208320 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1432111

[EFL EWS Bot]

Comment on attachment 208320 [details]
Patch

Attachment 208320 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1396120

[Divakar]

Created attachment 208333 [details]
Patch

[Divakar]

Created attachment 208334 [details]
Patch

[Divakar]

Created attachment 208335 [details]
Patch

[Divakar]

Corrected error and updated the patch.

[Benjamin Poulain]

Comment on attachment 208335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208335&action=review

> Source/WTF/wtf/Platform.h:1061
> +#if PLATFORM(EFL)
> +#define HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP 0
> +#endif
> +

This is not okay.

[Divakar]

(In reply to comment #12)
> (From update of attachment 208335 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208335&action=review
> 
> > Source/WTF/wtf/Platform.h:1061
> > +#if PLATFORM(EFL)
> > +#define HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP 0
> > +#endif
> > +
> 
> This is not okay.
do you want it to be enabled?

[Benjamin Poulain]

(In reply to comment #13) 
> > This is not okay.
> do you want it to be enabled?

No!!!
This should not be in this file.

A quick grep shows it is not defined anywhere, you should probably remove HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP from settings.

[Divakar]

Created attachment 208534 [details]
Patch

[EFL EWS Bot]

Comment on attachment 208534 [details]
Patch

Attachment 208534 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1441567

[Chris Dumez]

Comment on attachment 208534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208534&action=review

> Source/WebCore/page/Settings.cpp:131
>      , m_textAutosizingWindowSizeOverride(320, 480)

Why are we keeping this line if we are removing HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP?

[Jaehun Lim]

(In reply to comment #17)
> (From update of attachment 208534 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208534&action=review
> 
> > Source/WebCore/page/Settings.cpp:131
> >      , m_textAutosizingWindowSizeOverride(320, 480)
> 
> Why are we keeping this line if we are removing HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP?

"windows size" is used to adjust the font size. If it is not override, "visible contents size" is used instead of it. http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/TextAutosizer.cpp#L116

I think this line is necessary to activate TextAutosizing for the big screen. But I don't like it.

Johe Mellor filed the related bug, https://bugs.webkit.org/show_bug.cgi?id=94371

[Gyuyoung Kim]

Comment on attachment 208534 [details]
Patch

r- because of failing efl-wk2.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.