Bug 104494 - REGRESSION(r137090): Caused new test failures when JavaScript is embedded in SVG (Requested by mrobinson on #webkit).
Summary: REGRESSION(r137090): Caused new test failures when JavaScript is embedded in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 104477
  Show dependency treegraph
 
Reported: 2012-12-09 14:03 PST by WebKit Review Bot
Modified: 2012-12-23 09:30 PST (History)
2 users (show)

See Also:


Attachments
ROLLOUT of r137090 (1.45 KB, patch)
2012-12-09 14:04 PST, WebKit Review Bot
no flags Details | Formatted Diff | Diff
jhbuild config changes to patch the regression (5.06 KB, patch)
2012-12-22 18:44 PST, Dan Winship
mrobinson: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-12-09 14:03:53 PST
http://trac.webkit.org/changeset/137090 broke the build:
Caused new test failures when JavaScript is embedded in SVG (Requested by mrobinson on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-12-09 14:04:33 PST
Created attachment 178437 [details]
ROLLOUT of r137090

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Dan Winship 2012-12-22 18:44:55 PST
Created attachment 180611 [details]
jhbuild config changes to patch the regression

(the libxml2 patch has been committed upstream now)
Comment 3 WebKit Review Bot 2012-12-23 09:09:16 PST
Comment on attachment 180611 [details]
jhbuild config changes to patch the regression

Rejecting attachment 180611 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15511038
Comment 4 Dan Winship 2012-12-23 09:30:40 PST
oops, added the "Reviewed by" line to Tools/ChangeLog and committed by hand.