RESOLVED INVALID104493
REGRESSION (r137090): 15 layout test failures 
https://bugs.webkit.org/show_bug.cgi?id=104493
Summary REGRESSION (r137090): 15 layout test failures
Zan Dobersek
Reported 2012-12-09 13:12:01 PST
Bumping to libxml2 2.9.0 in r137090 is causing layout test failures. http://trac.webkit.org/changeset/137090 All but one test seem to be failing because of JavaScript being placed inside SVG. This is probably a libxml2 issue that should be bisected and possibly reported.
Attachments
Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-12-09 14:10:48 PST
Waiting on this because the tests are skipped for the moment. Once bisection of libxml is complete we can figure out again whether or not it's more prudent to roll out or update libxml.
Zan Dobersek
Comment 2 2012-12-16 07:02:53 PST
(In reply to comment #1) > Waiting on this because the tests are skipped for the moment. Once bisection of libxml is complete we can figure out again whether or not it's more prudent to roll out or update libxml. Forgot to paste the list of the failing tests. http/tests/security/xss-DENIED-xml-external-entity.xhtml svg/custom/deep-dynamic-updates.svg svg/custom/foreignObject-crash-on-hover.xml svg/custom/js-update-gradient.svg svg/custom/js-update-path-changes.svg svg/custom/js-update-path-removal.svg svg/custom/js-update-pattern-child.svg svg/custom/js-update-pattern.svg svg/custom/js-update-polygon-changes.svg svg/custom/js-update-polygon-removal.svg svg/custom/js-update-stop-linked-gradient.svg svg/custom/js-update-stop.svg svg/custom/js-update-transform-addition.svg svg/custom/js-update-transform-changes.svg svg/custom/text-xy-updates-SVGList.xhtml The http test is being fixed in bug #104680. The cause to other failures was bisected and reported to the GNOME bugzilla by Dan: https://bugzilla.gnome.org/show_bug.cgi?id=689958
Martin Robinson
Comment 3 2012-12-16 07:30:29 PST
Just for reference, the we had to update libxml to update libsoup. It would be tough to delay the libsoup update for too long (and the process of rolling out the patches would be fairly painful). If this continues to be an issue, maybe we can do the work necessary to lower the version requirements for libxml in libsoup.
Dan Winship
Comment 4 2012-12-16 08:22:29 PST
Actually the libxml bump was to support Fedora 18. (Apache links against the system libxml, but gets run against the jhbuilt libxml when running tests, so the jhbuilt one needs to be at least as new as the system one.) However, until the other F18 / apache 2.4 patch lands, you can't run the tests on F18 anyway, so we could just revert for now
Martin Robinson
Comment 5 2012-12-16 08:46:33 PST
(In reply to comment #4) > Actually the libxml bump was to support Fedora 18. (Apache links against the system libxml, but gets run against the jhbuilt libxml when running tests, so the jhbuilt one needs to be at least as new as the system one.) > > However, until the other F18 / apache 2.4 patch lands, you can't run the tests on F18 anyway, so we could just revert for now Ah, I recall now! Personally I'm fine without either waiting for the fix or rolling out for now.
Zan Dobersek
Comment 6 2012-12-16 08:51:28 PST
Insanity Wolf called, said we could just include Apache in the Jhbuild moduleset ... Anyway, at least to my knowledge the bump to 2.9.0 isn't blocking anyone's work and given that we would bump to 2.9.0 sooner or later I think it's not worth it to downgrade now. There was positive response on the GNOME bug so I believe this will get fixed in reasonable time and hopefully a new 2.9 release will be available.
Note You need to log in before you can comment on or make changes to this bug.