Bug 104481 - [GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
: [GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and Acc...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Hajime Morrita
: Gtk
Depends on:
Blocks: 98376
  Show dependency treegraph
 
Reported: 2012-12-09 04:41 PST by Alejandro Piñeiro
Modified: 2012-12-10 01:38 PST (History)
4 users (show)

See Also:


Attachments
Fixed the bug (1.98 KB, patch)
2012-12-09 04:46 PST, Alejandro Piñeiro
no flags Details | Formatted Diff | Diff
Patch (1.71 KB, patch)
2012-12-09 23:35 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro Piñeiro 2012-12-09 04:41:27 PST
Currently AccessibilityUIElementGtk lacks the implementation of the methods isSelectable and isMultiSelectable. This is one of the problems blocking bug 98376
Comment 1 Alejandro Piñeiro 2012-12-09 04:46:39 PST
Created attachment 178411 [details]
Fixed the bug
Comment 2 Alejandro Piñeiro 2012-12-09 08:40:45 PST
Chris, could you please review this? As I said is a really easy patch.
Comment 3 Martin Robinson 2012-12-09 09:20:29 PST
Comment on attachment 178411 [details]
Fixed the bug

Are there any tests for this issue?
Comment 4 WebKit Review Bot 2012-12-09 23:29:01 PST
Comment on attachment 178411 [details]
Fixed the bug

Clearing flags on attachment: 178411

Committed r137111: <http://trac.webkit.org/changeset/137111>
Comment 5 WebKit Review Bot 2012-12-09 23:29:04 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Hajime Morrita 2012-12-09 23:35:46 PST
Reopening to attach new patch.
Comment 7 Hajime Morrita 2012-12-09 23:35:49 PST
Created attachment 178481 [details]
Patch
Comment 8 Hajime Morrita 2012-12-09 23:37:21 PST
Comment on attachment 178481 [details]
Patch

Oops. DId something wrong. I'm sorry for disturbing.
Comment 9 Alejandro Piñeiro 2012-12-10 01:38:52 PST
Just a little explanation, although the bug is already FIXED.

(In reply to comment #3)
> (From update of attachment 178411 [details])
> Are there any tests for this issue?

Yes, the test already exist, and it is selection-states.html. As I said on comment 0, there are two reasons this test were failing on bug 98376. So I created this bug in order to isolate one of the problems. Bug 98376 would be solved (so the test would be working) as soon as we get a new ATK release and we update the bots requirements, so we could remove it from the TestExpectations as a Fail.