Bug 104461 - Don't unconditionally repaint compositing layers when their size changes
Summary: Don't unconditionally repaint compositing layers when their size changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 104637
  Show dependency tree / graph
 
Reported: 2012-12-08 18:11 PST by Simon Fraser (smfr)
Modified: 2013-01-03 09:49 PST (History)
12 users (show)

See Also:

Attachments
Patch (5.58 KB, patch)
2012-12-08 18:15 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (2.57 KB, patch)
2012-12-11 22:47 PST, Simon Fraser (smfr) 		jamesr: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-12-08 18:11:41 PST 
Don't unconditionally repaint compositing layers when their size changes
Comment 1 Simon Fraser (smfr) 2012-12-08 18:15:27 PST 
Created attachment 178389 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-12-08 18:16:11 PST 
<rdar://problem/12842382>
Comment 3 Sam Weinig 2012-12-09 17:36:05 PST 
Comment on attachment 178389 [details]
Patch

Eek!
Comment 4 Simon Fraser (smfr) 2012-12-10 15:46:35 PST 
http://trac.webkit.org/changeset/137215
Comment 5 Chris Dumez 2012-12-10 23:39:19 PST 
The test added in this patch seems to be failing on EFL port:
--- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/compositing/repaint/resize-repaint-expected.txt
+++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/compositing/repaint/resize-repaint-actual.txt
@@ -12,9 +12,6 @@
           (position 8.00 8.00)
           (bounds 402.00 207.00)
           (drawsContent 1)
-          (repaint rects
-            (rect 0.00 1.00 402.00 1.00)
-          )
         )
       )
     )
Comment 6 Simon Fraser (smfr) 2012-12-11 08:36:18 PST 
I didn't think EFL even did compositing. Has that changed? It looks like this port doesn't have the code to track repaint rects on GraphicsLayers. The test should be marked as failing in TestExpectations.
Comment 7 Chris Dumez 2012-12-11 08:40:16 PST 
(In reply to comment #6)
> I didn't think EFL even did compositing. Has that changed? It looks like this port doesn't have the code to track repaint rects on GraphicsLayers. The test should be marked as failing in TestExpectations.

Yes, we have enabled accelerated compositing in WK2 EFL about 1 month ago (using coordinated graphics). Thank you for the indication about tracking repaint rects.
I have already marked the test as failing in TestExpectations until we implement the missing functionality.
Comment 8 Simon Fraser (smfr) 2012-12-11 22:38:33 PST 
The fix for bug 104626 undid most of this optimization.
Comment 9 Simon Fraser (smfr) 2012-12-11 22:47:40 PST 
Created attachment 178971 [details]
Patch
Comment 10 Simon Fraser (smfr) 2012-12-12 15:35:12 PST 
http://trac.webkit.org/changeset/137526