Bug 104429 – [CMake] Consolidate list of files to build for WebCore plugin support

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Laszlo Gombos]

It seems to me that we can consolidate the list of files to build in the CMake build system and move some some of the files from PlatformXXX.cmake to CMakeLists.txt.

[Laszlo Gombos]

Created attachment 178330 [details]
proposed patch

I only had the opportunity to test it on the EFL port.

[Laszlo Gombos]

Created attachment 178570 [details]
rebase CMakeLists.txt

[Laszlo Gombos]

Created attachment 178579 [details]
right patch this time

[Laszlo Gombos]

Rob, can you help review this patch ?

[Rob Buis]

Comment on attachment 178579 [details]
right patch this time

View in context: https://bugs.webkit.org/attachment.cgi?id=178579&action=review

> Source/WebCore/PlatformBlackBerry.cmake:-255
> -        plugins/PluginDataNone.cpp

Is it correct this one was removed from the list? If it is correct, is it not in use anymore and can we remove the PluginDataNone.cpp?

[Laszlo Gombos]

Created attachment 186244 [details]
keep PluginDataNone.cpp for BlackBerry

Thanks Rob for the review. You're right in that PluginDataNone.cpp is still needed for the BlackBerry port. 

It seems to me that the file is only used by the BlackBerry port only and can be removed if the BlackBerry port starts to use USE(PLATFORM_STRATEGIES).

[Build Bot]

Comment on attachment 186244 [details]
keep PluginDataNone.cpp for BlackBerry

Attachment 186244 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16357200

[Build Bot]

Comment on attachment 186244 [details]
keep PluginDataNone.cpp for BlackBerry

Attachment 186244 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16353281

[Rob Buis]

I think this may need another pass, it seems to not pass on win and gtk.

[Patrick R. Gansterer]

(In reply to comment #9)
> I think this may need another pass, it seems to not pass on win and gtk.
Gtk & Win do not use CMake, so this failures seam unrelated.

[Rob Buis]

(In reply to comment #10)
> (In reply to comment #9)
> > I think this may need another pass, it seems to not pass on win and gtk.
> Gtk & Win do not use CMake, so this failures seam unrelated.

You are correct. However, efl-wk2 also seems to fail. Laszlo, you want to check and maybe upload a new patch against ToT?

[Laszlo Gombos]

Created attachment 201356 [details]
rebase on top of r149876

[Rob Buis]

Comment on attachment 201356 [details]
rebase on top of r149876

Looks good.

[WebKit Commit Bot]

Comment on attachment 201356 [details]
rebase on top of r149876

Clearing flags on attachment: 201356

Committed r149899: <http://trac.webkit.org/changeset/149899>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.