See the attached example. The vertical-rl case fails.
Created attachment 178307 [details] Test case.
Created attachment 179348 [details] Patch ExclusionShapes no longer maintain a private "internal" coordinate system, they're now defined in logical coordinates. The createExclusionShape() method now handles the one-time conversion from physical to logical coordinates.
Comment on attachment 179348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179348&action=review Fix looks ok. Looks like you forgot the ChangeLogs :). > Source/WebCore/rendering/ExclusionShape.cpp:68 > +static inline FloatRect physicalRectToLogical(const FloatRect& r, float logicalBoxHeight, WritingMode writingMode) s/r/rect/ > Source/WebCore/rendering/ExclusionShape.cpp:77 > +static inline FloatPoint physicalPointToLogical(const FloatPoint& p, float logicalBoxHeight, WritingMode writingMode) s/p/point/ > Source/WebCore/rendering/ExclusionShape.cpp:86 > +static inline FloatSize physicalSizeToLogical(const FloatSize& s, WritingMode writingMode) s/s/size/ > Source/WebCore/rendering/ExclusionShape.cpp:145 > + exclusionShape->m_boundingBox = FloatRect(logicalCenter - logicalRadii, logicalRadii + logicalRadii); logicalRadii + logicalRadii seems to be inconsistent with radius * 2 that you used previously. :)
Created attachment 179755 [details] Patch Added the ChangeLog, made the suggested changes.
Comment on attachment 179755 [details] Patch Attachment 179755 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15366809 New failing tests: fast/frames/sandboxed-iframe-attribute-parsing.html
Created attachment 179830 [details] Patch Resubmitting original patch since the Mac failure that caused the commit-bot to reject this patch also failed without this patch.
Comment on attachment 179830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179830&action=review LGTM. Just a snippet. R=me > Source/WebCore/rendering/ExclusionShape.cpp:145 > + exclusionShape->m_boundingBox = FloatRect(logicalCenter - logicalRadii, logicalRadii + logicalRadii); 2 * radii
Comment on attachment 179830 [details] Patch Clearing flags on attachment: 179830 Committed r138043: <http://trac.webkit.org/changeset/138043>
All reviewed patches have been landed. Closing bug.