Bug 104413 - There is no need to change cached resource storage policy through ResourceHandleClient
Summary: There is no need to change cached resource storage policy through ResourceHan...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-07 16:30 PST by Alexey Proskuryakov
Modified: 2012-12-07 16:39 PST (History)
2 users (show)

See Also:

Attachments
proposed patch (8.90 KB, patch)
2012-12-07 16:33 PST, Alexey Proskuryakov 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-12-07 16:30:08 PST 
There are two willCacheResource delegates in ResourceHandleClient, one that can replace the whole resource, and another that can change CacheStoragePolicy only. 

It's very confusing. And all the latter is ever used for is to prevent storing to disk when private browsing is enabled.

But private browsing storage session has 0 disk cache capacity, so it never stores anything anyway! So, I'd like to remove this code.
Comment 1 Alexey Proskuryakov 2012-12-07 16:33:20 PST 
Created attachment 178301 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2012-12-07 16:39:36 PST 
Committed <http://trac.webkit.org/changeset/136998>.