Bug 104403 - nrwt: use the default logic for skipping platform-specific tests for chromium
Summary: nrwt: use the default logic for skipping platform-specific tests for chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-07 14:32 PST by Dirk Pranke
Modified: 2012-12-10 14:43 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.13 KB, patch)
2012-12-07 14:33 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
fix ChangeLogs (4.64 KB, patch)
2012-12-07 14:37 PST, Dirk Pranke 		senorblanco: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-12-07 14:32:57 PST 
nrwt: use the default logic for skipping platform-specific tests for chromium
Comment 1 Dirk Pranke 2012-12-07 14:33:30 PST 
Created attachment 178279 [details]
Patch
Comment 2 Dirk Pranke 2012-12-07 14:37:16 PST 
Created attachment 178280 [details]
fix ChangeLogs
Comment 3 Stephen White 2012-12-07 14:43:28 PST 
Comment on attachment 178280 [details]
fix ChangeLogs

View in context: https://bugs.webkit.org/attachment.cgi?id=178280&action=review

> LayoutTests/platform/chromium-android/TestExpectations:-11
> -# Skip tests of other platforms to save time.
> -platform/gtk [ WontFix ]
> -platform/mac [ WontFix ]
> -platform/mac-wk2 [ WontFix ]
> -platform/qt [ WontFix ]
> -platform/win [ WontFix ]

If we don't change the code above (see below), we should probably change these to Skip instead.

> LayoutTests/platform/chromium/TestExpectations:-241
> -# Run the Mac-specific platform tests, but only to check for crashes.
> -platform/gtk [ WontFix ]
> -platform/mac [ WontFix ]

This looks like it was intentional, actually -- this comment suggests we really do want to run the off-platform tests if there's an expectation, just to look for crashes.  I have no idea if it ever caught anything, though.
Comment 4 Dirk Pranke 2012-12-07 15:00:29 PST 
(In reply to comment #3)
> (From update of attachment 178280 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178280&action=review
> 
> > LayoutTests/platform/chromium-android/TestExpectations:-11
> > -# Skip tests of other platforms to save time.
> > -platform/gtk [ WontFix ]
> > -platform/mac [ WontFix ]
> > -platform/mac-wk2 [ WontFix ]
> > -platform/qt [ WontFix ]
> > -platform/win [ WontFix ]
> 
> If we don't change the code above (see below), we should probably change these to Skip instead.
> 
> > LayoutTests/platform/chromium/TestExpectations:-241
> > -# Run the Mac-specific platform tests, but only to check for crashes.
> > -platform/gtk [ WontFix ]
> > -platform/mac [ WontFix ]
> 
> This looks like it was intentional, actually -- this comment suggests we really do want to run the off-platform tests if there's an expectation, just to look for crashes.  I have no idea if it ever caught anything, though.

Yes, we did intentionally use to run the platform-specific tests for other ports. At some point a while ago we decided to change this behavior to be more consistent with the other ports, but I never actually implemented it until now.
Comment 5 Stephen White 2012-12-07 15:01:45 PST 
Comment on attachment 178280 [details]
fix ChangeLogs

OK, cool!  r=me
Comment 6 Dirk Pranke 2012-12-10 14:43:38 PST 
Committed r137208: <http://trac.webkit.org/changeset/137208>