Bug 104401 – [WK2] Network process should use a correct storage session in private browsing mode

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alexey Proskuryakov]

It should!

<rdar://problem/12838490>

[Alexey Proskuryakov]

Created attachment 178278 [details]
proposed patch

[Early Warning System Bot]

Comment on attachment 178278 [details]
proposed patch

Attachment 178278 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15183560

[Alexey Proskuryakov]

Created attachment 178282 [details]
with a build fix

[Early Warning System Bot]

Comment on attachment 178282 [details]
with a build fix

Attachment 178282 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15188454

[Alexey Proskuryakov]

Created attachment 178285 [details]
more build fixing

[Brady Eidson]

Comment on attachment 178285 [details]
more build fixing

View in context: https://bugs.webkit.org/attachment.cgi?id=178285&action=review

> Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.h:46
> -    RemoteNetworkingContext(bool needsSiteSpecificQuirks, bool localFileContentSniffingEnabled);
> +    RemoteNetworkingContext(bool needsSiteSpecificQuirks, bool localFileContentSniffingEnabled, bool privateBrowsingEnabled);

Could we make this be enums instead of bools?

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/136997>.

> Could we make this be enums instead of bools?

I'm not sure if we really need to, at least not yet. We primarily use enums for readability, but when we're done hooking up all the arguments, there will be no mysterious false and true literals. Of course, there is the added benefit of type safety, which is worth considering too.