104401 – [WK2] Network process should use a correct storage session in private browsing mode

Bug 104401 - [WK2] Network process should use a correct storage session in private browsing mode

Summary: [WK2] Network process should use a correct storage session in private browsin...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKit2 (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Alexey Proskuryakov

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2012-12-07 14:20 PST by Alexey Proskuryakov
Modified:	2012-12-07 16:19 PST (History)
CC List:	5 users (show)

See Also:

Attachments
proposed patch (21.79 KB, patch) 2012-12-07 14:31 PST, Alexey Proskuryakov	webkit-ews: commit-queue-	Details \| Formatted Diff \| Diff
with a build fix (21.71 KB, patch) 2012-12-07 14:41 PST, Alexey Proskuryakov	webkit-ews: commit-queue-	Details \| Formatted Diff \| Diff
more build fixing (21.71 KB, patch) 2012-12-07 14:52 PST, Alexey Proskuryakov	beidson: review+	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexey Proskuryakov 2012-12-07 14:20:36 PST

It should!

<rdar://problem/12838490>

Comment 1 Alexey Proskuryakov 2012-12-07 14:31:58 PST

Created attachment 178278 [details]
proposed patch

Comment 2 Early Warning System Bot 2012-12-07 14:39:57 PST

Comment on attachment 178278 [details]
proposed patch

Attachment 178278 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15183560

Comment 3 Alexey Proskuryakov 2012-12-07 14:41:30 PST

Created attachment 178282 [details]
with a build fix

Comment 4 Early Warning System Bot 2012-12-07 14:47:20 PST

Comment on attachment 178282 [details]
with a build fix

Attachment 178282 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15188454

Comment 5 Alexey Proskuryakov 2012-12-07 14:52:52 PST

Created attachment 178285 [details]
more build fixing

Comment 6 Brady Eidson 2012-12-07 16:06:04 PST

Comment on attachment 178285 [details]
more build fixing

View in context: https://bugs.webkit.org/attachment.cgi?id=178285&action=review

> Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.h:46
> -    RemoteNetworkingContext(bool needsSiteSpecificQuirks, bool localFileContentSniffingEnabled);
> +    RemoteNetworkingContext(bool needsSiteSpecificQuirks, bool localFileContentSniffingEnabled, bool privateBrowsingEnabled);

Could we make this be enums instead of bools?

Comment 7 Alexey Proskuryakov 2012-12-07 16:19:48 PST

Committed <http://trac.webkit.org/changeset/136997>.

> Could we make this be enums instead of bools?

I'm not sure if we really need to, at least not yet. We primarily use enums for readability, but when we're done hooking up all the arguments, there will be no mysterious false and true literals. Of course, there is the added benefit of type safety, which is worth considering too.