Bug 104385 - [BlackBerry] Remove no-op line in WebPage.cpp
Summary: [BlackBerry] Remove no-op line in WebPage.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-07 12:03 PST by Rob Buis
Modified: 2013-01-04 02:12 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2012-12-07 12:05 PST, Rob Buis 		tonikitoo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2012-12-07 12:03:09 PST 
SSIA
Comment 1 Rob Buis 2012-12-07 12:05:48 PST 
Created attachment 178249 [details]
Patch
Comment 2 Antonio Gomes 2012-12-07 13:09:09 PST 
Comment on attachment 178249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178249&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:-4096
> -    tPoint.m_screenPos = tPoint.m_screenPos;

is not it a typo? point.m_screenPoint?
Comment 3 Rob Buis 2012-12-07 13:59:06 PST 
Hi Antonio,

(In reply to comment #2)
> (From update of attachment 178249 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=178249&action=review
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:-4096
> > -    tPoint.m_screenPos = tPoint.m_screenPos;
> 
> is not it a typo? point.m_screenPoint?

I don't think so, anyway the "Platform::TouchPoint tPoint = point;" just above makes them equal. The only point I can see to this line is if it would have used d->mapFromTransformed in the past, but I removed that (badly :)).
Comment 4 Rob Buis 2013-01-04 02:12:48 PST 
This was landed in r137031, closing.