RESOLVED FIXED 104385
[BlackBerry] Remove no-op line in WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=104385
Summary [BlackBerry] Remove no-op line in WebPage.cpp
Rob Buis
Reported 2012-12-07 12:03:09 PST
SSIA
Attachments
Patch (1.42 KB, patch)
2012-12-07 12:05 PST, Rob Buis
tonikitoo: review+
Rob Buis
Comment 1 2012-12-07 12:05:48 PST
Antonio Gomes
Comment 2 2012-12-07 13:09:09 PST
Comment on attachment 178249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178249&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:-4096 > - tPoint.m_screenPos = tPoint.m_screenPos; is not it a typo? point.m_screenPoint?
Rob Buis
Comment 3 2012-12-07 13:59:06 PST
Hi Antonio, (In reply to comment #2) > (From update of attachment 178249 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178249&action=review > > > Source/WebKit/blackberry/Api/WebPage.cpp:-4096 > > - tPoint.m_screenPos = tPoint.m_screenPos; > > is not it a typo? point.m_screenPoint? I don't think so, anyway the "Platform::TouchPoint tPoint = point;" just above makes them equal. The only point I can see to this line is if it would have used d->mapFromTransformed in the past, but I removed that (badly :)).
Rob Buis
Comment 4 2013-01-04 02:12:48 PST
This was landed in r137031, closing.
Note You need to log in before you can comment on or make changes to this bug.