Bug 104363 – fast/frames/sandboxed-iframe-scripting.html contains very misleading comments.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Mike West]

http://trac.webkit.org/browser/trunk/LayoutTests/fast/frames/sandboxed-iframe-scripting.html claims to verify that "removing the sandbox='allow-scripts' attribute at runtime prevents new scripts from launching, but existing ones keep running.". It does not verify this.

Not only does it not verify this, it shouldn't verify this, as the spec states: "These flags only take effect when the nested browsing context of the iframe is navigated. Removing them, or removing the entire sandbox attribute, has no effect on an already-loaded page."

I'm trying to add console warnings for blocked JavaScript, and this case confused me for longer than I care to admit in a public forum. :)

[Mike West]

(In reply to comment #0)
> Not only does it not verify this, it shouldn't verify this, as the spec states: "These flags only take effect when the nested browsing context of the iframe is navigated. Removing them, or removing the entire sandbox attribute, has no effect on an already-loaded page."

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-sandbox

In short, we're doing the right thing, but the comments make it sound like the wrong thing. I'll put up a patch in a moment to clear up the comments. :)

[Mike West]

Created attachment 178197 [details]
Patch

[Mike West]

Hey Jochen, would you be comfortable reviewing this change?

[Mike West]

Comment on attachment 178197 [details]
Patch

Thanks, Darin.

[WebKit Review Bot]

Comment on attachment 178197 [details]
Patch

Clearing flags on attachment: 178197

Committed r136963: <http://trac.webkit.org/changeset/136963>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.