Bug 104355 - Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
Summary: Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-07 02:21 PST by jochen
Modified: 2012-12-07 10:27 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2012-12-07 02:23 PST, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-12-07 02:21:41 PST
Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
Comment 1 jochen 2012-12-07 02:23:23 PST
Created attachment 178186 [details]
Patch
Comment 2 Dirk Pranke 2012-12-07 09:07:40 PST
Comment on attachment 178186 [details]
Patch

is there a particular reason to do this with an env variable rather than a DRT command line flag?
Comment 3 jochen 2012-12-07 10:09:08 PST
Mainly because that's the way chromium development was setup: https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment

(so all the buildbots set that variable etc..)

An alternative would be to teach our tools to translate the env variable to a command line flag, and content_shell to translate it back, but that seems a bit over complicated
Comment 4 Dirk Pranke 2012-12-07 10:14:38 PST
Comment on attachment 178186 [details]
Patch

OK.
Comment 5 WebKit Review Bot 2012-12-07 10:26:58 PST
Comment on attachment 178186 [details]
Patch

Clearing flags on attachment: 178186

Committed r136962: <http://trac.webkit.org/changeset/136962>
Comment 6 WebKit Review Bot 2012-12-07 10:27:01 PST
All reviewed patches have been landed.  Closing bug.