RESOLVED FIXED104355
Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers 
https://bugs.webkit.org/show_bug.cgi?id=104355
Summary Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout ...
jochen
Reported 2012-12-07 02:21:41 PST
Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
Attachments
Patch (1.41 KB, patch)
2012-12-07 02:23 PST, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-12-07 02:23:23 PST
Created attachment 178186 [details] Patch
Dirk Pranke
Comment 2 2012-12-07 09:07:40 PST
Comment on attachment 178186 [details] Patch is there a particular reason to do this with an env variable rather than a DRT command line flag?
jochen
Comment 3 2012-12-07 10:09:08 PST
Mainly because that's the way chromium development was setup: https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment (so all the buildbots set that variable etc..) An alternative would be to teach our tools to translate the env variable to a command line flag, and content_shell to translate it back, but that seems a bit over complicated
Dirk Pranke
Comment 4 2012-12-07 10:14:38 PST
Comment on attachment 178186 [details] Patch OK.
WebKit Review Bot
Comment 5 2012-12-07 10:26:58 PST
Comment on attachment 178186 [details] Patch Clearing flags on attachment: 178186 Committed r136962: <http://trac.webkit.org/changeset/136962>
WebKit Review Bot
Comment 6 2012-12-07 10:27:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.