RESOLVED FIXED 104338
IndexedDB: Replace int64 with int64_t 
https://bugs.webkit.org/show_bug.cgi?id=104338
Summary IndexedDB: Replace int64 with int64_t
Michael Pruett
Reported 2012-12-06 20:31:33 PST
With r136714, one use of the non-standard type int64 was introduced into IDBFactory.cpp. This type should be changed to the C99/C++11 int64_t type. The int64 type is defined in Chromium's basictypes.h but is not defined for other platforms.
Attachments
Patch (1.88 KB, patch)
2012-12-06 20:32 PST, Michael Pruett 		no flags
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2012-12-06 20:38 PST, Michael Pruett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Pruett
Comment 1 2012-12-06 20:32:34 PST
Created attachment 178147 [details] Patch
WebKit Review Bot
Comment 2 2012-12-06 20:35:56 PST
Attachment 178147 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Pruett
Comment 3 2012-12-06 20:38:06 PST
Created attachment 178148 [details] Patch
Kentaro Hara
Comment 4 2012-12-06 22:04:25 PST
Comment on attachment 178148 [details] Patch ok
WebKit Review Bot
Comment 5 2012-12-06 23:03:28 PST
Comment on attachment 178148 [details] Patch Clearing flags on attachment: 178148 Committed r136923: <http://trac.webkit.org/changeset/136923>
WebKit Review Bot
Comment 6 2012-12-06 23:03:32 PST
All reviewed patches have been landed. Closing bug.
Alec Flett
Comment 7 2012-12-07 09:53:15 PST
sorry about that..
Note You need to log in before you can comment on or make changes to this bug.