Bug 104338 - IndexedDB: Replace int64 with int64_t
Summary: IndexedDB: Replace int64 with int64_t
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-06 20:31 PST by Michael Pruett
Modified: 2012-12-07 09:53 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2012-12-06 20:32 PST, Michael Pruett 		no flags Details | Formatted Diff | Diff
Patch (1.90 KB, patch)
2012-12-06 20:38 PST, Michael Pruett 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Pruett 2012-12-06 20:31:33 PST 
With r136714, one use of the non-standard type int64 was introduced into IDBFactory.cpp. This type should be changed to the C99/C++11 int64_t type.

The int64 type is defined in Chromium's basictypes.h but is not defined for other platforms.
Comment 1 Michael Pruett 2012-12-06 20:32:34 PST 
Created attachment 178147 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-06 20:35:56 PST 
Attachment 178147 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Pruett 2012-12-06 20:38:06 PST 
Created attachment 178148 [details]
Patch
Comment 4 Kentaro Hara 2012-12-06 22:04:25 PST 
Comment on attachment 178148 [details]
Patch

ok
Comment 5 WebKit Review Bot 2012-12-06 23:03:28 PST 
Comment on attachment 178148 [details]
Patch

Clearing flags on attachment: 178148

Committed r136923: <http://trac.webkit.org/changeset/136923>
Comment 6 WebKit Review Bot 2012-12-06 23:03:32 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Alec Flett 2012-12-07 09:53:15 PST 
sorry about that..