Bug 104336 – Refactoring: Rename HTMLFormControlElement::required to isRequired

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Refactoring: Rename HTMLFormControlElement::required to isRequired

[Kent Tamura]

Created attachment 178143 [details]
Patch

[Kentaro Hara]

Comment on attachment 178143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178143&action=review

> Source/WebCore/ChangeLog:3
> +        Refactoring: Rename HTMLFormControlElement::required to isRequired

What's the rationale for the renaming? It sounds reasonable to keep the name consistent with IDL attribute names, even if those IDL attributes are [Reflect].

> Source/WebCore/ChangeLog:8
> +        m_required should be m_isRequired, and rquired() should be

Typo: rquired()

> Source/WebCore/ChangeLog:10
> +        attributes are are [Reflected].

Typo: are are

[Kent Tamura]

Comment on attachment 178143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178143&action=review

>> Source/WebCore/ChangeLog:3
>> +        Refactoring: Rename HTMLFormControlElement::required to isRequired
> 
> What's the rationale for the renaming? It sounds reasonable to keep the name consistent with IDL attribute names, even if those IDL attributes are [Reflect].

The rationale is to conform to the coding style.
required() looks like a getter function for the IDL attribute, but it's not.  It's confusing.

[Kentaro Hara]

Comment on attachment 178143 [details]
Patch

ah, makes sense.

[Kent Tamura]

Created attachment 178161 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 178161 [details]
Patch for landing

Clearing flags on attachment: 178161

Committed r136925: <http://trac.webkit.org/changeset/136925>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.