Bug 104331 – Review page is super flakey now

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Simon Fraser (smfr)]

The review page regressed significantly recently. I've observed
1. page jumps all over the place when typing
2. some keypresses in a comment cause the comment to get committed and scroll to the top of the page
3. selection sometimes disappears after command-C to copy
4. Console spews: TypeError: 'undefined' is not a function (evaluating 'container.remove()') code-review.js:1191

Please fix.

[Simon Fraser (smfr)]

Created attachment 178128 [details]
Crap at bottom of page

Why does copying add crap at the bottom of the page?

[Ojan Vafai]

(In reply to comment #0)
> The review page regressed significantly recently. I've observed
> 1. page jumps all over the place when typing
> 2. some keypresses in a comment cause the comment to get committed and scroll to the top of the page

I have no idea what recent changes could have caused this.

> 3. selection sometimes disappears after command-C to copy
> 4. Console spews: TypeError: 'undefined' is not a function (evaluating 'container.remove()') code-review.js:1191

Whoops. I used node.remove(), which is shipping in Chrome. I should have used $(node).remove(). Will fix this now. Hopefully that will also address whatever is causing 1/2, but I don't really see hoow 1/2 are recent regressions. Please let me know if you still see those after the fix for 3/4.

[Ojan Vafai]

Created attachment 178130 [details]
Patch

[Ojan Vafai]

Committed r136916: <http://trac.webkit.org/changeset/136916>

[Ojan Vafai]

Let me know if you're still seeing problems.

[Simon Fraser (smfr)]

Seems better.