WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
104302
JPEGImageDecoder should use SharedBuffer::getSomeData() instead of data()
https://bugs.webkit.org/show_bug.cgi?id=104302
Summary
JPEGImageDecoder should use SharedBuffer::getSomeData() instead of data()
Hin-Chung Lam
Reported
2012-12-06 14:15:38 PST
JPEGImageDecoder calls data() to consolidate the entire buffer into one piece. This involves memcpys and can possibly avoided by using getSomeData().
Attachments
Add attachment
proposed patch, testcase, etc.
noel gordon
Comment 1
2013-04-15 08:04:47 PDT
Noticed in the animated webp patch
bug 113124
, that a member variable m_demux (a webp demux object needed for decoding) is used to read the SharedBuffer::data(). The m_demux object internally maintains pointers into that data(). That's probably ok for a single pass through decode(). However, for progessive decoding of large webp images, decode() is called multiple times. Any new calls SharedBuffer::data() in any decode() might cause that data() to be consolidated if I'm reading this bug correctly?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug