Bug 104301 - nrwt: remove deprecated ORWT compatibility command line flags
Summary: nrwt: remove deprecated ORWT compatibility command line flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on: 104298 104299
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-06 14:15 PST by Dirk Pranke
Modified: 2012-12-12 14:41 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.57 KB, patch)
2012-12-06 14:17 PST, Dirk Pranke 		eric: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-12-06 14:15:21 PST 
nrwt: remove deprecated ORWT compatibility command line flags
Comment 1 Dirk Pranke 2012-12-06 14:17:37 PST 
Created attachment 178081 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-12-06 15:23:14 PST 
I really appreciate you cleaning all this up.
Comment 3 WebKit Review Bot 2012-12-06 15:25:10 PST 
Comment on attachment 178081 [details]
Patch

Attachment 178081 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15187046
Comment 4 Dirk Pranke 2012-12-12 11:09:30 PST 
Ossy, can you let me know when it's safe to land this w/o breaking the http://build.webkit.sed.hu/ waterfall? I'd update the config if I had any idea how to do that :).
Comment 5 Csaba Osztrogonác 2012-12-12 12:07:28 PST 
(In reply to comment #4)
> Ossy, can you let me know when it's safe to land this w/o breaking the http://build.webkit.sed.hu/ waterfall? I'd update the config if I had any idea how to do that :).

I removed the obsolete --no-launch-safari and --use-remote-links-to-tests
from the master.cfg of build.webkit.sed.hu. Now the test command is:
 command = ["perl", "./Tools/Scripts/run-webkit-tests", "--no-new-test-results", "--debug-rwt-logging", "--no-sample-on-timeout", "--results-directory", "layout-test-results", "--builder-name", WithProperties("%(buildername)s"), WithProperties("--%(configuration)s")]

Is there anything else I should remove?
Comment 6 Dirk Pranke 2012-12-12 12:13:10 PST 
(In reply to comment #5)
> (In reply to comment #4)
> > Ossy, can you let me know when it's safe to land this w/o breaking the http://build.webkit.sed.hu/ waterfall? I'd update the config if I had any idea how to do that :).
> 
> I removed the obsolete --no-launch-safari and --use-remote-links-to-tests
> from the master.cfg of build.webkit.sed.hu. Now the test command is:
>  command = ["perl", "./Tools/Scripts/run-webkit-tests", "--no-new-test-results", "--debug-rwt-logging", "--no-sample-on-timeout", "--results-directory", "layout-test-results", "--builder-name", WithProperties("%(buildername)s"), WithProperties("--%(configuration)s")]
> 
> Is there anything else I should remove?

You probably want to add --no-show-results back in to replace --no-launch-safari.

Otherwise, this should be all you need.
Comment 7 Csaba Osztrogonác 2012-12-12 12:15:15 PST 
yes, I noticed I missed to add --no-show-results first. But I managed to do it for the second update. :)
Comment 8 Dirk Pranke 2012-12-12 14:41:03 PST 
Committed r137517: <http://trac.webkit.org/changeset/137517>