Bug 104296 – new-run-webkit-tests --lint-test-files seems to be broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Stephen White]

new-run-webkit-tests --lint-test-files is giving this on Linux:

No handlers could be found for logger "__main__"

It doesn't seem to do the lint check, either.

[Dirk Pranke]

Created attachment 178085 [details]
Patch

[Dirk Pranke]

landing this unreviewed since the lint build step is borked ...

[Dirk Pranke]

Committed r136896: <http://trac.webkit.org/changeset/136896>

[Csaba Osztrogonác]

(In reply to comment #3)
> Committed r136896: <http://trac.webkit.org/changeset/136896>

It broke --debug-rwt option and made the output on the bots non-verbose. :(
I put back the removed line - https://trac.webkit.org/changeset/136929

It would be great if you would be more careful in the future if you 
modify common codes and prefer rolling out buggy changes instead 
of buggy unreviewed quick fixes and causing more problem.

[Dirk Pranke]

(In reply to comment #4)
> (In reply to comment #3)
> > Committed r136896: <http://trac.webkit.org/changeset/136896>
> 
> It broke --debug-rwt option and made the output on the bots non-verbose. :(
> I put back the removed line - https://trac.webkit.org/changeset/136929
> 
> It would be great if you would be more careful in the future if you 
> modify common codes and prefer rolling out buggy changes instead 
> of buggy unreviewed quick fixes and causing more problem.

Argh, you're right, sorry! The reason I didn't roll out the buggy change was because there was about six changes stacked on top of each other, and figuring out which ones needed to be rolled out, in which order,  would have been non-trivial. Still probably not a great excuse, though. I will try to do better in the future.