Bug 104281 - [WK2] Track private browsing session in network process
Summary: [WK2] Track private browsing session in network process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-06 11:39 PST by Alexey Proskuryakov
Modified: 2012-12-06 14:15 PST (History)
3 users (show)

See Also:


Attachments
proposed patch (10.63 KB, patch)
2012-12-06 11:43 PST, Alexey Proskuryakov
jberlin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-12-06 11:39:02 PST
Need to create a session when enabling private browsing, and destroy it when disabling.
Comment 1 Alexey Proskuryakov 2012-12-06 11:43:39 PST
Created attachment 178048 [details]
proposed patch
Comment 2 Jessie Berlin 2012-12-06 14:06:54 PST
Comment on attachment 178048 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=178048&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:80
> +// FIXME (NetworkProcess): Don't create an unnecessary session when using network process.

This comment needs to be indented correctly.
Comment 3 Alexey Proskuryakov 2012-12-06 14:15:38 PST
Committed <http://trac.webkit.org/changeset/136888>.