Bug 104277 - internals.settings.setEnableCompositingForFixedPosition() should be called before onload
Summary: internals.settings.setEnableCompositingForFixedPosition() should be called be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on:
Blocks: 96839 102543
  Show dependency tree / graph
 
Reported: 2012-12-06 11:03 PST by Xianzhu Wang
Modified: 2012-12-06 14:01 PST (History)
3 users (show)

See Also:

Attachments
Patch (10.92 KB, patch)
2012-12-06 11:30 PST, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-12-06 11:03:33 PST 
Some tests calls internals.settings.setEnableCompositingForFixedPosition() in the onload handler, which may be too late because the compositing requirements may have been computed. This causes the tests flaky or failure to test the expected behavior.
Comment 1 Xianzhu Wang 2012-12-06 11:30:45 PST 
Created attachment 178043 [details]
Patch
Comment 2 James Robinson 2012-12-06 12:24:03 PST 
Alternately, can we make that call re-evaluate compositing requirements?  We normally do that whenever style changes.
Comment 3 Xianzhu Wang 2012-12-06 13:14:28 PST 
(In reply to comment #2)
> Alternately, can we make that call re-evaluate compositing requirements?  We normally do that whenever style changes.

I'm afraid there might be still other places in the code not expecting change of the settings.
Comment 4 WebKit Review Bot 2012-12-06 14:01:41 PST 
Comment on attachment 178043 [details]
Patch

Clearing flags on attachment: 178043

Committed r136885: <http://trac.webkit.org/changeset/136885>
Comment 5 WebKit Review Bot 2012-12-06 14:01:46 PST 
All reviewed patches have been landed.  Closing bug.