WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104277
internals.settings.setEnableCompositingForFixedPosition() should be called before onload
https://bugs.webkit.org/show_bug.cgi?id=104277
Summary
internals.settings.setEnableCompositingForFixedPosition() should be called be...
Xianzhu Wang
Reported
2012-12-06 11:03:33 PST
Some tests calls internals.settings.setEnableCompositingForFixedPosition() in the onload handler, which may be too late because the compositing requirements may have been computed. This causes the tests flaky or failure to test the expected behavior.
Attachments
Patch
(10.92 KB, patch)
2012-12-06 11:30 PST
,
Xianzhu Wang
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Xianzhu Wang
Comment 1
2012-12-06 11:30:45 PST
Created
attachment 178043
[details]
Patch
James Robinson
Comment 2
2012-12-06 12:24:03 PST
Alternately, can we make that call re-evaluate compositing requirements? We normally do that whenever style changes.
Xianzhu Wang
Comment 3
2012-12-06 13:14:28 PST
(In reply to
comment #2
)
> Alternately, can we make that call re-evaluate compositing requirements? We normally do that whenever style changes.
I'm afraid there might be still other places in the code not expecting change of the settings.
WebKit Review Bot
Comment 4
2012-12-06 14:01:41 PST
Comment on
attachment 178043
[details]
Patch Clearing flags on attachment: 178043 Committed
r136885
: <
http://trac.webkit.org/changeset/136885
>
WebKit Review Bot
Comment 5
2012-12-06 14:01:46 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug