RESOLVED INVALID104275
Leaf nodes should use parent tree scope 
https://bugs.webkit.org/show_bug.cgi?id=104275
Summary Leaf nodes should use parent tree scope
Elliott Sprehn
Reported 2012-12-06 10:38:56 PST
Text nodes should use parent tree scope
Attachments
Patch (2.77 KB, patch)
2012-12-06 10:53 PST, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (2.80 KB, patch)
2012-12-06 12:54 PST, Elliott Sprehn 		morrita: review+
morrita: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Elliott Sprehn
Comment 1 2012-12-06 10:53:52 PST
Created attachment 178037 [details] Patch
WebKit Review Bot
Comment 2 2012-12-06 12:06:23 PST
Comment on attachment 178037 [details] Patch Attachment 178037 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15159784 New failing tests: editing/selection/select-across-readonly-input-5.html editing/pasteboard/copy-null-characters.html editing/input/paste-text-ending-with-interchange-newline.html dom/xhtml/level3/core/nodeinsertbefore02.xhtml editing/pasteboard/drop-text-events.html editing/pasteboard/drag-drop-input-textarea.html http/tests/local/file-url-sent-as-referer.html editing/pasteboard/5665299.html editing/selection/select-across-readonly-input-4.html dom/xhtml/level3/core/documentadoptnode12.xhtml editing/pasteboard/drag-drop-url-text.html fast/canvas/canvas-bg-multiple-removal.html dom/xhtml/level3/core/documentgetxmlstandalone05.xhtml editing/selection/select-across-readonly-input-1.html editing/selection/crash-on-drag-with-mutation-events.html editing/shadow/shadow-selection-not-exported.html editing/shadow/compare-positions-in-nested-shadow.html editing/pasteboard/drop-inputtext-acquires-style.html editing/pasteboard/copy-paste-pre-line-content.html editing/pasteboard/copy-paste-first-line-in-textarea.html editing/shadow/selection-of-shadowroot.html editing/selection/select-across-readonly-input-3.html fast/css-generated-content/block-after.html editing/spelling/spellcheck-async-mutation.html dom/xhtml/level3/core/nodereplacechild13.xhtml fast/dom/XMLSerializer-doctype.html fast/dom/createDocumentType2.html editing/selection/select-across-readonly-input-2.html dom/xhtml/level3/core/nodecomparedocumentposition02.xhtml dom/xhtml/level3/core/documentgetdoctype01.xhtml WebFrameTest.FindInPage
Dimitri Glazkov (Google)
Comment 3 2012-12-06 12:14:17 PST
You've made Ews elves angry.
Elliott Sprehn
Comment 4 2012-12-06 12:45:06 PST
(In reply to comment #2) > (From update of attachment 178037 [details]) > Attachment 178037 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15159784 > > New failing tests: > .. Woah, that seems crazy I could have failed so many tests... looking into this.
Elliott Sprehn
Comment 5 2012-12-06 12:49:44 PST
Comment on attachment 178037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178037&action=review > Source/WebCore/dom/Document.h:1555 > + if (isContainerNode() && parentNode()) Err I'm dumb. This should be !isContainerNode(). I originally had isTextNode() and changed it.
Elliott Sprehn
Comment 6 2012-12-06 12:54:20 PST
Created attachment 178065 [details] Patch
Hajime Morrita
Comment 7 2012-12-06 21:49:47 PST
Comment on attachment 178065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178065&action=review This is clever. cq- since this seems incompatible to your another patch. > Source/WebCore/dom/Document.h:1557 > + if (!isContainerNode() && parentNode()) This can be tuned a bit more - parentNode() has one flag check so the result better be stored. - if !isContainerNode(), it cannot be in shadow, so the tree scope is always document.
Elliott Sprehn
Comment 8 2013-01-04 14:35:25 PST
My patch on Bug 59816 seems to have worked as I'm not seeing any perf regressions on the page cyclers so we don't need this anymore.
Note You need to log in before you can comment on or make changes to this bug.