RESOLVED WONTFIX 104273
Let acceleratedCompositingForScrollableFramesEnabled flag be independent with forceCompositingMode flag 
https://bugs.webkit.org/show_bug.cgi?id=104273
Summary Let acceleratedCompositingForScrollableFramesEnabled flag be independent with...
Xianzhu Wang
Reported 2012-12-06 09:55:35 PST
We may need to enable acceleratedCompositingForScrollableFramesEnabled without enabling forceCompositingMode.
Attachments
Patch (36.06 KB, patch)
2012-12-06 10:51 PST, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Patch (34.11 KB, patch)
2012-12-07 12:41 PST, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-12-06 10:51:25 PST
Created attachment 178034 [details] Patch
Build Bot
Comment 2 2012-12-06 19:04:35 PST
Comment on attachment 178034 [details] Patch Attachment 178034 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15173617 New failing tests: compositing/scrollable-frames/overflow-iframe-enter-compositing.html compositing/scrollable-frames/overflow-iframe-layer.html
Xianzhu Wang
Comment 3 2012-12-07 12:41:14 PST
Created attachment 178257 [details] Patch
Xianzhu Wang
Comment 4 2012-12-07 12:42:02 PST
Unable to debug the mac failures for now, so left the tests still under platform/chromium.
Xianzhu Wang
Comment 5 2012-12-10 13:45:52 PST
@jamesr, could you please review the change? Thanks!
Xianzhu Wang
Comment 6 2012-12-10 15:18:24 PST
Discussed with James offline. Seems not beneficial because forceCompositingMode is almost required in case we composite frames.
Eric Seidel (no email)
Comment 7 2013-01-04 00:54:25 PST
Comment on attachment 178257 [details] Patch Cleared review? from attachment 178257 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Xianzhu Wang
Comment 8 2013-01-04 09:39:18 PST
(In reply to comment #7) > (From update of attachment 178257 [details]) > Cleared review? from attachment 178257 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). This bug has been closed because the fix seems not necessary.
Xianzhu Wang
Comment 9 2013-01-04 09:40:01 PST
Thanks for clearing the review flag :)
Note You need to log in before you can comment on or make changes to this bug.