Bug 104262 – [EFL] Fix build warning in StyleResolver.cpp using gcc 4.7.2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Sujin Park]

When I compile in Ubuntu 12.10(gcc 4.7.2), I got bellow errors

Source/WebCore/CMakeFiles/webcore_efl.dir/css/ViewportStyleResolver.cpp.o
In file included from /home/sujin/workspace/WebKit/Source/WebCore/rendering/style/RenderStyle.h:39:0,
                 from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.h:30,
                 from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:30:
/home/sujin/workspace/WebKit/Source/WebCore/platform/graphics/FontDescription.h: In static member function ‘static WTF::PassRefPtr<WebCore::RenderStyle> WebCore::StyleResolver::styleForDocument(WebCore::Document*, WebCore::CSSFontSelector*)’:
/home/sujin/workspace/WebKit/Source/WebCore/platform/graphics/FontDescription.h:165:112: error: ‘glyphOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
/home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:1508:28: note: ‘glyphOrientation’ was declared here
In file included from /home/sujin/workspace/WebKit/Source/WebCore/rendering/style/RenderStyle.h:39:0,
                 from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.h:30,
                 from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:30:
/home/sujin/workspace/WebKit/Source/WebCore/platform/graphics/FontDescription.h:164:83: error: ‘fontOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
/home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:1507:21: note: ‘fontOrientation’ was declared here
/home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp: In member function ‘void WebCore::StyleResolver::_ZN7WebCore13StyleResolver10updateFontEv.part.218()’:
/home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2140:5: error: ‘parentGlyphOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
/home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2137:28: note: ‘parentGlyphOrientation’ was declared here
/home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2140:5: error: ‘parentFontOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
/home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2136:21: note: ‘parentFontOrientation’ was declared here
In file included from /home/sujin/workspace/WebKit/Source/WebCore/rendering/style/RenderStyle.h:39:0,
                 from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.h:30,
                 from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:30:
/home/sujin/workspace/WebKit/Source/WebCore/platform/graphics/FontDescription.h:165:112: error: ‘childGlyphOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
/home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2133:28: note: ‘childGlyphOrientation’ was declared here
In file included from /home/sujin/workspace/WebKit/Source/WebCore/rendering/style/RenderStyle.h:39:0,
                 from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.h:30,
                 from /home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:30:
/home/sujin/workspace/WebKit/Source/WebCore/platform/graphics/FontDescription.h:164:83: error: ‘childFontOrientation’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
/home/sujin/workspace/WebKit/Source/WebCore/css/StyleResolver.cpp:2132:21: note: ‘childFontOrientation’ was declared here
cc1plus: all warnings being treated as errors
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/css/StyleResolver.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/all] Error 2
make: *** [all] Error 2

[Sujin Park]

Created attachment 178011 [details]
Patch

[Sujin Park]

Created attachment 178193 [details]
Patch

[WebKit Review Bot]

Comment on attachment 178193 [details]
Patch

Clearing flags on attachment: 178193

Committed r136952: <http://trac.webkit.org/changeset/136952>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.