Bug 104259 - Fix webgl-depth-texture.html to match the test expectation
Summary: Fix webgl-depth-texture.html to match the test expectation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Kalyan
URL:
Keywords:
Depends on:
Blocks: 102991
  Show dependency treegraph
 
Reported: 2012-12-06 06:51 PST by Kalyan
Modified: 2012-12-07 15:07 PST (History)
8 users (show)

See Also:


Attachments
patch (1.80 KB, patch)
2012-12-06 07:22 PST, Kalyan
no flags Details | Formatted Diff | Diff
patch (1.80 KB, patch)
2012-12-06 08:09 PST, Kalyan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kalyan 2012-12-06 06:51:57 PST
The text expectation for this testcase expects to check for FrameBuffer status after creating the framebuffer.
Comment 1 Kalyan 2012-12-06 07:22:32 PST
Created attachment 178010 [details]
patch
Comment 2 WebKit Review Bot 2012-12-06 07:24:07 PST
Attachment 178010 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
LayoutTests/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kalyan 2012-12-06 07:45:28 PST
Comment on attachment 178010 [details]
patch

will update a new patch
Comment 4 Kalyan 2012-12-06 08:09:58 PST
Created attachment 178015 [details]
patch
Comment 5 Kenneth Russell 2012-12-07 15:03:06 PST
Comment on attachment 178015 [details]
patch

The basic problem seems to be that Intel's driver reports the framebuffer as complete after adding only the depth or depth/stencil texture, and the test only asserts that the FBO is complete if it was incomplete with just that attachment. The change to the test matches the current expectations for all the ports, so it seems OK. I will take care of upstreaming this change to the Khronos WebGL repo. r=me
Comment 6 WebKit Review Bot 2012-12-07 15:07:50 PST
Comment on attachment 178015 [details]
patch

Clearing flags on attachment: 178015

Committed r136990: <http://trac.webkit.org/changeset/136990>
Comment 7 WebKit Review Bot 2012-12-07 15:07:55 PST
All reviewed patches have been landed.  Closing bug.