Bug 104252 - Enable CSS3 position offset for CSS Masking.
Summary: Enable CSS3 position offset for CSS Masking.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords: WebExposed
Depends on:
Blocks: 95389
  Show dependency treegraph
 
Reported: 2012-12-06 04:20 PST by Alexis Menard (darktears)
Modified: 2012-12-07 18:35 PST (History)
9 users (show)

See Also:


Attachments
Patch (25.92 KB, patch)
2012-12-06 04:55 PST, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Rebased, should work on Chromium EWS as CSS3 background-position offsets are activated (26.08 KB, patch)
2012-12-07 13:08 PST, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-12-06 04:20:35 PST
Enable CSS3 position offset for CSS Masking.
Comment 1 Alexis Menard (darktears) 2012-12-06 04:55:55 PST
Created attachment 177994 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-06 07:07:02 PST
Comment on attachment 177994 [details]
Patch

Attachment 177994 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15152862

New failing tests:
fast/masking/parsing-mask.html
Comment 3 Alexis Menard (darktears) 2012-12-06 07:09:22 PST
(In reply to comment #2)
> (From update of attachment 177994 [details])
> Attachment 177994 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/15152862
> 
> New failing tests:
> fast/masking/parsing-mask.html

chromium doesn't enable yet the CSS3 background position, it is tracked here : 

https://bugs.webkit.org/show_bug.cgi?id=104253
Comment 4 WebKit Review Bot 2012-12-06 07:40:36 PST
Comment on attachment 177994 [details]
Patch

Attachment 177994 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15154906

New failing tests:
fast/masking/parsing-mask.html
Comment 5 Dirk Schulze 2012-12-06 15:55:58 PST
(In reply to comment #4)
> (From update of attachment 177994 [details])
> Attachment 177994 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/15154906
> 
> New failing tests:
> fast/masking/parsing-mask.html

Can you add the test to the expectatsion list with expecting fail please? I will look at the patch later.
Comment 6 Dirk Schulze 2012-12-06 21:53:49 PST
Comment on attachment 177994 [details]
Patch

The patch itself looks good to me. Please try to solve the problems with the bots by setting the exception files
Comment 7 Alexis Menard (darktears) 2012-12-07 13:08:31 PST
Created attachment 178261 [details]
Rebased, should work on Chromium EWS as CSS3 background-position offsets are activated
Comment 8 Dirk Schulze 2012-12-07 14:38:08 PST
(In reply to comment #7)
> Created an attachment (id=178261) [details]
> Rebased, should work on Chromium EWS as CSS3 background-position offsets are activated

Hm, the bots seem to be pretty unstable on running the tests. Even on background-pos test failed once.
Comment 9 Dirk Schulze 2012-12-07 18:00:37 PST
Comment on attachment 178261 [details]
Rebased, should work on Chromium EWS as CSS3 background-position offsets are activated

r=me
Comment 10 WebKit Review Bot 2012-12-07 18:34:59 PST
Comment on attachment 178261 [details]
Rebased, should work on Chromium EWS as CSS3 background-position offsets are activated

Clearing flags on attachment: 178261

Committed r137007: <http://trac.webkit.org/changeset/137007>
Comment 11 WebKit Review Bot 2012-12-07 18:35:03 PST
All reviewed patches have been landed.  Closing bug.