Bug 104243 - [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
Summary: [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-06 01:56 PST by Xiaobo Wang
Modified: 2012-12-07 02:23 PST (History)
6 users (show)

See Also:

Attachments
patch (21.76 KB, patch)
2012-12-06 03:10 PST, Xiaobo Wang 		rwlbuis: review+
Details | Formatted Diff | Diff
patch - final (22.52 KB, patch)
2012-12-07 01:37 PST, Xiaobo Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xiaobo Wang 2012-12-06 01:56:00 PST 
The current implementation of TestRunner::setCustomPolicyDelegate is not
completed.
1. Doesn't support originating for navigation request.
2. Doesn't support delegation of navigation response.

With these update we can enable tests in http/tests/download.
Comment 1 Xiaobo Wang 2012-12-06 03:10:25 PST 
Created attachment 177985 [details]
patch
Comment 2 Rob Buis 2012-12-06 06:19:47 PST 
Comment on attachment 177985 [details]
patch

LGTM. You could have stated what tests this fixes.
Comment 3 Xiaobo Wang 2012-12-07 01:37:04 PST 
Created attachment 178183 [details]
patch - final

Added tests fixed in ChangeLogs.
Comment 4 Charles Wei 2012-12-07 01:40:06 PST 
Comment on attachment 178183 [details]
patch - final

commit.
Comment 5 WebKit Review Bot 2012-12-07 02:23:02 PST 
Comment on attachment 178183 [details]
patch - final

Clearing flags on attachment: 178183

Committed r136940: <http://trac.webkit.org/changeset/136940>
Comment 6 WebKit Review Bot 2012-12-07 02:23:06 PST 
All reviewed patches have been landed.  Closing bug.