Bug 104241 - Internals.getElementByIdInShadowRoot is nonsense now.
Summary: Internals.getElementByIdInShadowRoot is nonsense now.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 87815
  Show dependency treegraph
 
Reported: 2012-12-06 01:51 PST by Shinya Kawanaka
Modified: 2012-12-06 05:39 PST (History)
2 users (show)

See Also:


Attachments
Patch (6.18 KB, patch)
2012-12-06 01:59 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch for landing (9.38 KB, patch)
2012-12-06 03:26 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-12-06 01:51:30 PST
We have ShadowRoot.getElementById() now. We should use it instead.
Comment 1 Shinya Kawanaka 2012-12-06 01:59:43 PST
Created attachment 177975 [details]
Patch
Comment 2 Kent Tamura 2012-12-06 02:57:49 PST
Comment on attachment 177975 [details]
Patch

ok
Comment 3 Kent Tamura 2012-12-06 02:58:30 PST
Comment on attachment 177975 [details]
Patch

Don't you need to remove some export symbol lists?
Comment 4 Shinya Kawanaka 2012-12-06 03:19:37 PST
(In reply to comment #3)
> (From update of attachment 177975 [details])
> Don't you need to remove some export symbol lists?

Thanks for the catch! I should remove some.
Comment 5 Shinya Kawanaka 2012-12-06 03:26:41 PST
Created attachment 177986 [details]
Patch for landing
Comment 6 Shinya Kawanaka 2012-12-06 03:27:08 PST
Comment on attachment 177986 [details]
Patch for landing

Waiting for bots green.
Comment 7 WebKit Review Bot 2012-12-06 05:39:43 PST
Comment on attachment 177986 [details]
Patch for landing

Clearing flags on attachment: 177986

Committed r136834: <http://trac.webkit.org/changeset/136834>
Comment 8 WebKit Review Bot 2012-12-06 05:39:47 PST
All reviewed patches have been landed.  Closing bug.