Bug 104230 - [V8] Implement v8StringWithoutIsolate()
Summary: [V8] Implement v8StringWithoutIsolate()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-05 23:58 PST by Kentaro Hara
Modified: 2012-12-06 01:21 PST (History)
1 user (show)

See Also:

Attachments
Patch (30.90 KB, patch)
2012-12-06 00:02 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-12-05 23:58:58 PST 
To make an Isolate mandatory in v8String(), we implement v8StringWithoutIsolate() for call sites that don't have an Isolate. Eventually we want to kill the method though.
Comment 1 Kentaro Hara 2012-12-06 00:02:10 PST 
Created attachment 177955 [details]
Patch
Comment 2 Adam Barth 2012-12-06 00:35:17 PST 
Comment on attachment 177955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177955&action=review

Same comment about using the word "deprecated"

> Source/WebCore/bindings/v8/Dictionary.cpp:105
> +    ASSERT(m_isolate);

Oh, it looks like we do have an m_isolate for Dictionary.  We should use that in the integer patch.
Comment 3 Kentaro Hara 2012-12-06 00:35:49 PST 
(In reply to comment #2)
> (From update of attachment 177955 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177955&action=review
> 
> Same comment about using the word "deprecated"

Sure.
Comment 4 Kentaro Hara 2012-12-06 01:20:09 PST 
Committed r136822: <http://trac.webkit.org/changeset/136822>