WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104230
[V8] Implement v8StringWithoutIsolate()
https://bugs.webkit.org/show_bug.cgi?id=104230
Summary
[V8] Implement v8StringWithoutIsolate()
Kentaro Hara
Reported
2012-12-05 23:58:58 PST
To make an Isolate mandatory in v8String(), we implement v8StringWithoutIsolate() for call sites that don't have an Isolate. Eventually we want to kill the method though.
Attachments
Patch
(30.90 KB, patch)
2012-12-06 00:02 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-12-06 00:02:10 PST
Created
attachment 177955
[details]
Patch
Adam Barth
Comment 2
2012-12-06 00:35:17 PST
Comment on
attachment 177955
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=177955&action=review
Same comment about using the word "deprecated"
> Source/WebCore/bindings/v8/Dictionary.cpp:105 > + ASSERT(m_isolate);
Oh, it looks like we do have an m_isolate for Dictionary. We should use that in the integer patch.
Kentaro Hara
Comment 3
2012-12-06 00:35:49 PST
(In reply to
comment #2
)
> (From update of
attachment 177955
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=177955&action=review
> > Same comment about using the word "deprecated"
Sure.
Kentaro Hara
Comment 4
2012-12-06 01:20:09 PST
Committed
r136822
: <
http://trac.webkit.org/changeset/136822
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug