Bug 104228 - Add win8/* to Chromium DEPS (r171376)
Summary: Add win8/* to Chromium DEPS (r171376)
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Takashi Sakamoto
Depends on:
Reported: 2012-12-05 23:28 PST by Takashi Sakamoto
Modified: 2012-12-07 03:50 PST (History)
5 users (show)

See Also:

Patch (1.23 KB, patch)
2012-12-05 23:36 PST, Takashi Sakamoto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Sakamoto 2012-12-05 23:28:14 PST
Current chromium/src/printing/printing.gyp requires win8:

        ['OS=="win"', {
          'dependencies': [

So need to checkout win8/* to roll Chromium DEPS to r171376.
Comment 1 Takashi Sakamoto 2012-12-05 23:36:16 PST
Created attachment 177952 [details]
Comment 2 Hajime Morrita 2012-12-05 23:38:41 PST
Comment on attachment 177952 [details]

Comment 3 Takashi Sakamoto 2012-12-05 23:47:42 PST
Comment on attachment 177952 [details]

Clearing flags on attachment: 177952

Committed r136811: <http://trac.webkit.org/changeset/136811>
Comment 4 Takashi Sakamoto 2012-12-05 23:47:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Emil A Eklund 2012-12-06 14:00:30 PST
This seems to have casued the win release bot fail, http://build.webkit.org/builders/Chromium%20Win%20Release/builds/51312
Comment 6 Tony Chang 2012-12-06 14:22:22 PST
src/printing depends on src/win8, which depends on src/chrome/tools/build/win/check_sdk_patch.py.

That's wrong. We need to break this dependency. Looking at win8.gyp, I would probably move the python script into win8. I'm not sure why it's in the chrome directory.
Comment 8 noel gordon 2012-12-07 03:50:08 PST

DEPS rolled to 171707, win release build bot went green \o/