WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104228
Add win8/* to Chromium DEPS (
r171376
)
https://bugs.webkit.org/show_bug.cgi?id=104228
Summary
Add win8/* to Chromium DEPS (r171376)
Takashi Sakamoto
Reported
2012-12-05 23:28:14 PST
Current chromium/src/printing/printing.gyp requires win8: ['OS=="win"', { 'dependencies': [ '../win8/win8.gyp:win8_util', ], So need to checkout win8/* to roll Chromium DEPS to
r171376
.
Attachments
Patch
(1.23 KB, patch)
2012-12-05 23:36 PST
,
Takashi Sakamoto
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Takashi Sakamoto
Comment 1
2012-12-05 23:36:16 PST
Created
attachment 177952
[details]
Patch
Hajime Morrita
Comment 2
2012-12-05 23:38:41 PST
Comment on
attachment 177952
[details]
Patch rs=me
Takashi Sakamoto
Comment 3
2012-12-05 23:47:42 PST
Comment on
attachment 177952
[details]
Patch Clearing flags on attachment: 177952 Committed
r136811
: <
http://trac.webkit.org/changeset/136811
>
Takashi Sakamoto
Comment 4
2012-12-05 23:47:46 PST
All reviewed patches have been landed. Closing bug.
Emil A Eklund
Comment 5
2012-12-06 14:00:30 PST
This seems to have casued the win release bot fail,
http://build.webkit.org/builders/Chromium%20Win%20Release/builds/51312
Tony Chang
Comment 6
2012-12-06 14:22:22 PST
src/printing depends on src/win8, which depends on src/chrome/tools/build/win/check_sdk_patch.py. That's wrong. We need to break this dependency. Looking at win8.gyp, I would probably move the python script into win8. I'm not sure why it's in the chrome directory.
noel gordon
Comment 7
2012-12-06 19:22:45 PST
https://src.chromium.org/viewvc/chrome?view=rev&revision=171652
noel gordon
Comment 8
2012-12-07 03:50:08 PST
http://trac.webkit.org/changeset/136939
DEPS rolled to 171707, win release build bot went green \o/
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug