Bug 104220 – [V8] Implement v8IntegerWithoutIsolate(int i)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

To make an Isolate mandatory in v8Integer(), we implement v8IntegerWithoutIsolate(int i) for call sites that don't have an Isolate. Eventually we want to kill v8IntegerWithoutIsolate(int i).

[Kentaro Hara]

Created attachment 177941 [details]
Patch

[Kentaro Hara]

Created attachment 177956 [details]
Patch

[Adam Barth]

Comment on attachment 177956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177956&action=review

You might also consider the name deprecatedV8Integer to inform people writing future patches that they shouldn't add more callers of this function.

> Source/WebCore/bindings/v8/Dictionary.cpp:300
> -        v8::Local<v8::Value> indexedValue = v8Array->Get(v8Integer(i));
> +        v8::Local<v8::Value> indexedValue = v8Array->Get(v8IntegerWithoutIsolate(i));

We should be able to store the isolate in a member variable of Dictionary.  Code isn't allowed to hold on to Dictionaries past the call frame in which they receive them.

[Kentaro Hara]

(In reply to comment #3)
> (From update of attachment 177956 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177956&action=review
> 
> You might also consider the name deprecatedV8Integer to inform people writing future patches that they shouldn't add more callers of this function.

Good idea. Will fix before landing.

> > Source/WebCore/bindings/v8/Dictionary.cpp:300
> > -        v8::Local<v8::Value> indexedValue = v8Array->Get(v8Integer(i));
> > +        v8::Local<v8::Value> indexedValue = v8Array->Get(v8IntegerWithoutIsolate(i));
> 
> We should be able to store the isolate in a member variable of Dictionary.

Oops, Dictionary already holds m_isolate. I can use it here. Will fix it.

[Kentaro Hara]

Committed r136819: <http://trac.webkit.org/changeset/136819>