Bug 104201 - Parameter event need to covert to RefPtr in the DeviceController::dispatchDeviceEvent
Summary: Parameter event need to covert to RefPtr in the DeviceController::dispatchDev...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kihong Kwon
URL:
Keywords:
Depends on:
Blocks: 97630
  Show dependency treegraph
 
Reported: 2012-12-05 18:08 PST by Kihong Kwon
Modified: 2012-12-05 19:38 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2012-12-05 18:14 PST, Kihong Kwon
no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2012-12-05 19:05 PST, Kihong Kwon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kihong Kwon 2012-12-05 18:08:22 PST
Parameter event need to covert to RefPtr in the DeviceController::dispatchDeviceEvent, but it is used PassRefPtr now.
This makes crash if there are more than one listener.
Comment 1 Kihong Kwon 2012-12-05 18:14:16 PST
Created attachment 177897 [details]
Patch
Comment 2 Laszlo Gombos 2012-12-05 18:42:18 PST
Comment on attachment 177897 [details]
Patch

r=me.

Nit: "No new tests. This just a bug fixing." does not make sense to me as bug fixes require tests.
Comment 3 Kihong Kwon 2012-12-05 19:05:35 PST
Created attachment 177909 [details]
Patch
Comment 4 Kihong Kwon 2012-12-05 19:07:44 PST
(In reply to comment #2)
> (From update of attachment 177897 [details])
> r=me.
> 
> Nit: "No new tests. This just a bug fixing." does not make sense to me as bug fixes require tests.

I got it, it can be tested with existing test cases.
I will change statement.

Thank you.
Comment 5 WebKit Review Bot 2012-12-05 19:38:47 PST
Comment on attachment 177909 [details]
Patch

Clearing flags on attachment: 177909

Committed r136791: <http://trac.webkit.org/changeset/136791>
Comment 6 WebKit Review Bot 2012-12-05 19:38:50 PST
All reviewed patches have been landed.  Closing bug.