Bug 104197 - Add user defaults to override system proxy settings for NetworkProcess on Mac
Summary: Add user defaults to override system proxy settings for NetworkProcess on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kiran Muppala
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-12-05 17:57 PST by Kiran Muppala
Modified: 2013-10-02 11:07 PDT (History)
8 users (show)

See Also:


Attachments
WIP Patch (7.35 KB, patch)
2012-12-06 15:28 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
WIP Patch (7.31 KB, patch)
2012-12-06 15:55 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
Patch (127.94 KB, patch)
2012-12-06 16:48 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
WIP Patch (128.03 KB, patch)
2012-12-06 17:10 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
WIP Patch (7.41 KB, patch)
2012-12-06 19:32 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
Patch (163.54 KB, patch)
2012-12-17 17:52 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
Patch (163.57 KB, patch)
2012-12-17 18:38 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
WIP Patch (163.56 KB, patch)
2013-01-08 16:46 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
Patch (172.94 KB, patch)
2013-01-08 19:03 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
Patch (7.67 KB, patch)
2013-01-08 20:39 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
Patch (7.67 KB, patch)
2013-01-08 21:34 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kiran Muppala 2012-12-05 17:57:13 PST
For internal testing and debugging, it is useful to have a defaults write to set the HTTP and HTTPS proxy specific to a WebKit2 client Application and not affect the system proxy settings on Mac.

This is related to https://bugs.webkit.org/show_bug.cgi?id=96456, which was originally intended for WebProcess but later rejected since InjectedBundle can be used for the same effect.  This bug is necessary since, Network Process does not use a InjectedBundle.
Comment 1 Kiran Muppala 2012-12-05 17:57:39 PST
<rdar://problem/12790572>
Comment 2 Kiran Muppala 2012-12-06 15:28:06 PST
Created attachment 178093 [details]
WIP Patch
Comment 3 Kiran Muppala 2012-12-06 15:55:27 PST
Created attachment 178097 [details]
WIP Patch
Comment 4 Kiran Muppala 2012-12-06 15:57:39 PST
(In reply to comment #3)
> Created an attachment (id=178097) [details]
> Patch

Removed unnecessary import of <CFNetwork/CFProxySupportPriv.h> from Source/WebKit2/NetworkProcess/mac/NetworkProcessMac.mm, based on review feedback from Stephanie Lewis.
Comment 5 Kiran Muppala 2012-12-06 16:48:14 PST
Created attachment 178108 [details]
Patch
Comment 6 Kiran Muppala 2012-12-06 16:50:12 PST
(In reply to comment #5)
> Created an attachment (id=178108) [details]
> Patch

Updated WebKitSystemInterface.h, libWebKitSystemInterfaceLion.a and libWebKitSystemInterfaceMountainLion.a.
Comment 7 Kiran Muppala 2012-12-06 17:10:30 PST
Created attachment 178115 [details]
WIP Patch
Comment 8 Kiran Muppala 2012-12-06 17:10:44 PST
(In reply to comment #7)
> Created an attachment (id=178115) [details]
> Patch

Fixed merge conflict.
Comment 9 Kiran Muppala 2012-12-06 19:32:44 PST
Created attachment 178137 [details]
WIP Patch
Comment 10 Kiran Muppala 2012-12-06 19:36:36 PST
(In reply to comment #9)
> Created an attachment (id=178137) [details]
> Patch

Rolled out the WebKitSytemInterface changes, since it should have been done after this bug was reviewed.  Hence, also removed the WebKitLibraries part of this patch.  Will re-include after review.

Also, fixed style issues with missing spaces in NetworkProcessMac.mm.  No, functional changes.
Comment 11 Build Bot 2012-12-07 00:44:00 PST
Comment on attachment 178137 [details]
WIP Patch

Attachment 178137 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15186277
Comment 12 Kiran Muppala 2012-12-17 17:52:11 PST
Created attachment 179841 [details]
Patch
Comment 13 Kiran Muppala 2012-12-17 17:52:58 PST
(In reply to comment #12)
> Created an attachment (id=179841) [details]
> Patch

Updated patch to resolve merge conflicts and included WebKitSystemInterface changes too.
Comment 14 Kiran Muppala 2012-12-17 18:38:54 PST
Created attachment 179851 [details]
Patch
Comment 15 Kiran Muppala 2012-12-17 18:39:21 PST
(In reply to comment #14)
> Created an attachment (id=179851) [details]
> Patch

Fixed merge conflict again.  No other changes.
Comment 16 Kiran Muppala 2013-01-08 16:46:38 PST
Created attachment 181801 [details]
WIP Patch
Comment 17 Kiran Muppala 2013-01-08 16:48:41 PST
(In reply to comment #16)
> Created an attachment (id=181801) [details]
> Patch

Fixed merge conflict.  Uploading for EWS analysis.
Comment 18 Kiran Muppala 2013-01-08 19:03:20 PST
Created attachment 181820 [details]
Patch
Comment 19 Kiran Muppala 2013-01-08 19:03:54 PST
(In reply to comment #18)
> Created an attachment (id=181820) [details]
> Patch

Updated WKSI libraries.
Comment 20 Stephanie Lewis 2013-01-08 20:07:36 PST
I would r+ this, but the new review policy is moving into place so we need to find one of the wk2 owners to look it over.
Comment 21 Kiran Muppala 2013-01-08 20:37:30 PST
Moved WKSI portion to https://bugs.webkit.org/show_bug.cgi?id=106410, thanks to Stephanie for giving me this idea to avoid rolling out the internal commit yet again.
Comment 22 Kiran Muppala 2013-01-08 20:39:17 PST
Created attachment 181833 [details]
Patch
Comment 23 Kiran Muppala 2013-01-08 20:39:49 PST
(In reply to comment #22)
> Created an attachment (id=181833) [details]
> Patch

Removed the WKSI portion.  No other change.
Comment 24 Build Bot 2013-01-08 20:57:14 PST
Comment on attachment 181833 [details]
Patch

Attachment 181833 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15760346
Comment 25 Kiran Muppala 2013-01-08 21:17:07 PST
(In reply to comment #24)
> (From update of attachment 181833 [details])
> Attachment 181833 [details] did not pass mac-ews (mac):
> Output: http://queues.webkit.org/results/15760346

D'oh, of course it will fail because the WKSI portion hasn't landed yet.
Comment 26 Kiran Muppala 2013-01-08 21:34:46 PST
Created attachment 181840 [details]
Patch
Comment 27 Kiran Muppala 2013-01-08 21:35:24 PST
(In reply to comment #26)
> Created an attachment (id=181840) [details]
> Patch

Resubmitting patch for EWS, since WKSI part has landed.
Comment 28 WebKit Review Bot 2013-01-09 14:32:10 PST
Comment on attachment 181840 [details]
Patch

Clearing flags on attachment: 181840

Committed r139241: <http://trac.webkit.org/changeset/139241>
Comment 29 WebKit Review Bot 2013-01-09 14:32:15 PST
All reviewed patches have been landed.  Closing bug.
Comment 30 Daniel Bates 2013-10-02 11:07:44 PDT
(In reply to comment #28)
> (From update of attachment 181840 [details])
> Clearing flags on attachment: 181840
> 
> Committed r139241: <http://trac.webkit.org/changeset/139241>

Fixed the Mac WebKit2 build when building without the network process by adding a ENABLE(NETWORK_PROCESS) guard around the constants WebKit2HTTPProxyDefaultsKey and WebKit2HTTPSProxyDefaultsKey. Committed this fix in r156776, <http://trac.webkit.org/changeset/156776>.