Bug 104164 - [Qt][Mac] Fix libxslt and libxml2 config tests
Summary: [Qt][Mac] Fix libxslt and libxml2 config tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andras Becsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-05 13:24 PST by Andras Becsi
Modified: 2012-12-06 06:03 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.59 KB, patch)
2012-12-05 13:27 PST, Andras Becsi 		hausmann: review+
hausmann: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2012-12-05 13:24:51 PST 
[Qt][Mac] Fix libxslt and libxml2 config tests
Comment 1 Andras Becsi 2012-12-05 13:27:40 PST 
Created attachment 177820 [details]
Patch
Comment 2 Simon Hausmann 2012-12-06 05:27:28 PST 
Comment on attachment 177820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177820&action=review

r=me with a small change before landing :)

> Tools/qmake/config.tests/libxslt/libxslt.pro:3
> +LIBS += -lxslt

I think the LIBS line should go into the mac scope, no? At least if we're using pkg-config we should not be doing LIBS += but solely rely on what pkg-config gives us.

Same in libxml2.pro
Comment 3 Andras Becsi 2012-12-06 06:03:28 PST 
Committed r136837: <http://trac.webkit.org/changeset/136837>