Bug 104161 - Empty parse cache when receiving a low memory warning
Summary: Empty parse cache when receiving a low memory warning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-05 13:22 PST by Oliver Hunt
Modified: 2012-12-05 23:07 PST (History)
1 user (show)

See Also:


Attachments
Patch (4.98 KB, patch)
2012-12-05 13:25 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (5.77 KB, patch)
2012-12-05 15:29 PST, Oliver Hunt
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2012-12-05 13:22:55 PST
Empty parse cache when receiving a low memory warning
Comment 1 Oliver Hunt 2012-12-05 13:25:36 PST
Created attachment 177819 [details]
Patch
Comment 2 Build Bot 2012-12-05 14:37:48 PST
Comment on attachment 177819 [details]
Patch

Attachment 177819 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15170218
Comment 3 Oliver Hunt 2012-12-05 15:29:10 PST
Created attachment 177844 [details]
Patch
Comment 4 Filip Pizlo 2012-12-05 15:38:04 PST
Comment on attachment 177844 [details]
Patch

R=me.  When does this get invoked?
Comment 5 Oliver Hunt 2012-12-05 15:43:55 PST
Committed r136773: <http://trac.webkit.org/changeset/136773>
Comment 6 Geoffrey Garen 2012-12-05 16:46:18 PST
Comment on attachment 177844 [details]
Patch

You should add a call to didAbandonObjectGraph(). How about inside discardAllCode()?
Comment 7 Geoffrey Garen 2012-12-05 23:07:56 PST
It looks like this patch only covers WebCore, and not other embedders of JavaScriptCore. I think we need a handler inside JavaScriptCore or WTF.