Bug 104146 – Web Inspector: Add shortcut to set visibility:hidden on elements in the ElementsPanel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

Web Inspector: Add shortcut to set visibility:hidden on elements in the ElementsPanel

Created attachment 177802 [details]
Patch

Created attachment 177840 [details]
Patch

pfeldman, thanks for the feedback.

I rewrote the patch to using cssStyleModel.

[WebKit Review Bot]

Comment on attachment 177840 [details]
Patch

Attachment 177840 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15147671

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Pavel Feldman]

Comment on attachment 177840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177840&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:777
> +        WebInspector.cssModel.getInlineStylesAsync(this.id, updateInlineVisibility);

Lets keep CSS -> DOM dependency one way. I.e. toggleInlineVisibility should be in CSSStyleModel and should accept node id (or node) as a parameter.

> Source/WebCore/inspector/front-end/treeoutline.js:377
> +    else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.H.code)

Hide is not generic enough to be dispatched from treeoutline. You should add explicit listener in the ElementsPanel.js that does it.

Created attachment 178244 [details]
Patch

(In reply to comment #5)

I updated the patch:

> (From update of attachment 177840 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177840&action=review
> 
> > Source/WebCore/inspector/front-end/DOMAgent.js:777
> > +        WebInspector.cssModel.getInlineStylesAsync(this.id, updateInlineVisibility);
> 
> Lets keep CSS -> DOM dependency one way. I.e. toggleInlineVisibility should be in CSSStyleModel and should accept node id (or node) as a parameter.

done

> > Source/WebCore/inspector/front-end/treeoutline.js:377
> > +    else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.H.code)
> 
> Hide is not generic enough to be dispatched from treeoutline. You should add explicit listener in the ElementsPanel.js that does it.

I found a spot in ElementsTreeOutline.js that seemed to fit.

[WebKit Review Bot]

Comment on attachment 178244 [details]
Patch

Clearing flags on attachment: 178244

Committed r136974: <http://trac.webkit.org/changeset/136974>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.