Bug 104144 – [CSS Regions] Don't apply region flow to fullscreen video playing

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Zoltan Horvath]

In case of full screen video playing we want to watch the video full screen without applying the region flow.

[Zoltan Horvath]

Created attachment 177797 [details]
proposed patch

[WebKit Review Bot]

Attachment 177797 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 177797 [details]
proposed patch

Attachment 177797 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15154530

New failing tests:
fast/regions/full-screen-video-from-region.html

[Zoltan Horvath]

Created attachment 179301 [details]
proposed patch, cr-linux, cr-mac pngs added

[WebKit Review Bot]

Comment on attachment 179301 [details]
proposed patch, cr-linux, cr-mac pngs added

Attachment 179301 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15315349

New failing tests:
fast/regions/full-screen-video-from-region.html

[Dave Hyatt]

Comment on attachment 179301 [details]
proposed patch, cr-linux, cr-mac pngs added

r=me

[WebKit Review Bot]

Comment on attachment 179301 [details]
proposed patch, cr-linux, cr-mac pngs added

Rejecting attachment 179301 [details] from commit-queue.

New failing tests:
fast/regions/full-screen-video-from-region.html
Full output: http://queues.webkit.org/results/15671040

[Zoltan Horvath]

Landed in: http://trac.webkit.org/changeset/138755

[Terry Anderson]

Added cr-linux baseline as requested: http://trac.webkit.org/changeset/138760

[Zoltan Horvath]

Thanks Terry. Closing bug.

[Ryosuke Niwa]

Copy & pasted from https://bugs.webkit.org/show_bug.cgi?id=102388

 Comment #4 From Ryosuke Niwa 2013-01-03 19:10:31 PST (-) [reply] 
I’m confused. There’s a commit: http://trac.webkit.org/changeset/138755 but this bug has no indication that Dave reviewed the patch.
 Comment #5 From Ryosuke Niwa 2013-01-03 19:11:00 PST (-) [reply] 
Anyhow, the test added by http://trac.webkit.org/changeset/138755 is crashing on Mac:
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r138769%20(4286)/results.html

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore                 0x000000010f55615b WebCore::RenderFlowThread::removeRenderBoxRegionInfo(WebCore::RenderBox*) + 459 (RenderFlowThread.cpp:449)
1   com.apple.WebCore                 0x000000010f555f63 WebCore::RenderFlowThread::removeFlowChildInfo(WebCore::RenderObject*) + 67 (RenderFlowThread.cpp:90)
2   com.apple.WebCore                 0x000000010f61b0b2 WebCore::RenderObject::removeFromRenderFlowThreadRecursive(WebCore::RenderFlowThread*) + 130 (RenderObject.cpp:2496)
3   com.apple.WebCore                 0x000000010f61b093 WebCore::RenderObject::removeFromRenderFlowThreadRecursive(WebCore::RenderFlowThread*) + 99 (RenderObject.cpp:2493)
4   com.apple.WebCore                 0x000000010f61b093 WebCore::RenderObject::removeFromRenderFlowThreadRecursive(WebCore::RenderFlowThread*) + 99 (RenderObject.cpp:2493)
5   com.apple.WebCore                 0x000000010f61b093 WebCore::RenderObject::removeFromRenderFlowThreadRecursive(WebCore::RenderFlowThread*) + 99 (RenderObject.cpp:2493)
6   com.apple.WebCore                 0x000000010f61b028 WebCore::RenderObject::removeFromRenderFlowThread() + 120 (RenderObject.cpp:2488)
7   com.apple.WebCore                 0x000000010f61af52 WebCore::RenderObject::willBeRemovedFromTree() + 354 (RenderObject.cpp:2470)
8   com.apple.WebCore                 0x000000010f61f3c5 WebCore::RenderObjectChildList::removeChildNode(WebCore::RenderObject*, WebCore::RenderObject*, bool) + 389 (RenderObjectChildList.cpp:92)
9   com.apple.WebCore                 0x000000010f60be54 WebCore::RenderObject::removeChild(WebCore::RenderObject*) + 164 (RenderObject.cpp:343)
10  com.apple.WebCore                 0x000000010f4653bb WebCore::RenderBlock::removeChild(WebCore::RenderObject*) + 1019 (RenderBlock.cpp:1195)
11  com.apple.WebCore                 0x000000010f56a966 WebCore::RenderObject::remove() + 70 (RenderObject.h:936)
12  com.apple.WebCore                 0x000000010f56a259 WebCore::RenderFullScreen::wrapRenderer(WebCore::RenderObject*, WebCore::RenderObject*, WebCore::Document*) + 425 (RenderFullScreen.cpp:132)
13  com.apple.WebCore                 0x000000010e600496 WebCore::Document::webkitWillEnterFullScreenForElement(WebCore::Element*) + 646 (Document.cpp:5212)
14  com.apple.WebKit                  0x000000010dc77ca6 -[WebKitFullScreenListener webkitWillEnterFullScreen] + 118 (WebKitFullScreenListener.mm:49)
15  DumpRenderTree                    0x000000010c888477 -[UIDelegate enterFullScreenWithListener:] + 39 (UIDelegate.mm:261)
16  com.apple.Foundation              0x00007fff86ffbdb5 __NSFireDelayedPerform + 358
17  com.apple.CoreFoundation          0x00007fff8a050da4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
18  com.apple.CoreFoundation          0x00007fff8a0508bd __CFRunLoopDoTimer + 557
19  com.apple.CoreFoundation          0x00007fff8a036099 __CFRunLoopRun + 1513
20  com.apple.CoreFoundation          0x00007fff8a0356b2 CFRunLoopRunSpecific + 290
21  com.apple.Foundation              0x00007fff8702389e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 268
22  DumpRenderTree                    0x000000010c84b839 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 5017 (DumpRenderTree.mm:1381)
23  DumpRenderTree                    0x000000010c84a42a runTestingServerLoop() + 282 (DumpRenderTree.mm:846)
24  DumpRenderTree                    0x000000010c849cf7 dumpRenderTree(int, char const**) + 391 (DumpRenderTree.mm:893)
25  DumpRenderTree                    0x000000010c84c029 main + 105 (DumpRenderTree.mm:931)
26  libdyld.dylib                     0x00007fff89ebe7e1 start + 1
 Comment #6 From Ryosuke Niwa 2013-01-03 19:11:20 PST (-) [reply] 
Also see the flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=full-screen-video-from-region.html

[Ryosuke Niwa]

Filed https://bugs.webkit.org/show_bug.cgi?id=106075 to track the test failure.

[Terry Anderson]

Zoltan, FYI: Did some further rebaselining for chromium. XP was missing and some other platforms had some slight pixel differences around the video timer. See http://trac.webkit.org/changeset/138799

[Terry Anderson]

(In reply to comment #13)
> Zoltan, FYI: Did some further rebaselining for chromium. XP was missing and some other platforms had some slight pixel differences around the video timer. See http://trac.webkit.org/changeset/138799

Looks like I missed the one for Lion: http://trac.webkit.org/changeset/138830