Bug 104143 – [WK2] Would like to queue messages while NetworkProcess is launching

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alexey Proskuryakov]

The code to queue messages while launching only exists in WebProcessProxy.

[Alexey Proskuryakov]

Created attachment 177798 [details]
proposed patch

[Anders Carlsson]

Comment on attachment 177798 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177798&action=review

> Source/WebKit2/Shared/ChildProcessProxy.cpp:128
> +    if (m_connection) {

Would be cleaner to just return early if m_connection is null.

[Build Bot]

Comment on attachment 177798 [details]
proposed patch

Attachment 177798 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15153519

[WebKit Review Bot]

Attachment 177798 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/Shared/ChildProcessProxy.h:48:  The parameter name "reply" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Created attachment 177812 [details]
with a Windows build fix

I don't understand the MSVC failure. Trying to fix by using public inheritance in ChildProcessProxy.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r136770>.