Bug 104143 - [WK2] Would like to queue messages while NetworkProcess is launching
Summary: [WK2] Would like to queue messages while NetworkProcess is launching
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-05 11:07 PST by Alexey Proskuryakov
Modified: 2012-12-05 15:29 PST (History)
9 users (show)

See Also:


Attachments
proposed patch (43.26 KB, patch)
2012-12-05 11:20 PST, Alexey Proskuryakov
andersca: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
with a Windows build fix (43.26 KB, patch)
2012-12-05 12:47 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-12-05 11:07:49 PST
The code to queue messages while launching only exists in WebProcessProxy.
Comment 1 Alexey Proskuryakov 2012-12-05 11:20:05 PST
Created attachment 177798 [details]
proposed patch
Comment 2 Anders Carlsson 2012-12-05 11:25:20 PST
Comment on attachment 177798 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177798&action=review

> Source/WebKit2/Shared/ChildProcessProxy.cpp:128
> +    if (m_connection) {

Would be cleaner to just return early if m_connection is null.
Comment 3 Build Bot 2012-12-05 12:20:56 PST
Comment on attachment 177798 [details]
proposed patch

Attachment 177798 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15153519
Comment 4 WebKit Review Bot 2012-12-05 12:23:07 PST
Attachment 177798 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/Shared/ChildProcessProxy.h:48:  The parameter name "reply" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alexey Proskuryakov 2012-12-05 12:47:56 PST
Created attachment 177812 [details]
with a Windows build fix

I don't understand the MSVC failure. Trying to fix by using public inheritance in ChildProcessProxy.
Comment 6 Alexey Proskuryakov 2012-12-05 15:29:38 PST
Committed <http://trac.webkit.org/r136770>.