Bug 104138 - [Gtk] add setting to enable WebGL errors on console
Summary: [Gtk] add setting to enable WebGL errors on console
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 525.x (Safari 3.2)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: arno.
URL:
Keywords:
Depends on: 107035
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-05 10:39 PST by arno.
Modified: 2013-01-25 11:40 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.76 KB, patch)
2012-12-05 10:42 PST, arno. 		no flags Details | Formatted Diff | Diff
wip patch (6.78 KB, patch)
2013-01-16 11:36 PST, arno. 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2012-12-05 10:39:16 PST 
Hi, it would be nice to allow setting webGLErrorsToConsoleEnabled
Comment 1 arno. 2012-12-05 10:42:51 PST 
Created attachment 177792 [details]
Patch

patch proposal
Comment 2 WebKit Review Bot 2012-12-05 10:47:25 PST 
Attachment 177792 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/gtk/webkit/webkitwebsettings.cpp:117:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebKit/gtk/webkit/webkitwebsettings.cpp:851:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebKit/gtk/webkit/webkitwebsettings.cpp:853:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/gtk/webkit/webkitwebsettings.cpp:854:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/gtk/webkit/webkitwebsettings.cpp:855:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/gtk/webkit/webkitwebsettings.cpp:856:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 6 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Martin Robinson 2012-12-21 04:00:25 PST 
I think perhaps it's not too interesting to add new API to WebKit1 unless it allows us to make the results of more tests match those of WebKit2. We plan to deprecate WebKit1 in favor of WebKit2 at some point.
Comment 4 arno. 2013-01-16 11:08:52 PST 
Comment on attachment 177792 [details]
Patch

Ok, I'll provide a patch for WebKit2 then
Comment 5 arno. 2013-01-16 11:36:59 PST 
Created attachment 183013 [details]
wip patch