Bug 104134 - [Qt] QWebView uses the mobile style and doesn't follow Qt's style
Summary: [Qt] QWebView uses the mobile style and doesn't follow Qt's style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Pierre Rossi
URL:
Keywords: Qt
Depends on:
Blocks: 103747
  Show dependency tree / graph
 
Reported: 2012-12-05 09:19 PST by Jocelyn Turcotte
Modified: 2012-12-06 07:02 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.42 KB, patch)
2012-12-05 14:58 PST, Pierre Rossi 		no flags Details | Formatted Diff | Diff
Patch (3.46 KB, patch)
2012-12-06 01:32 PST, Pierre Rossi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2012-12-05 09:19:42 PST 
SSIA
Comment 1 Jocelyn Turcotte 2012-12-05 09:37:53 PST 
For some reason this seems to happen only for the first QWebPage that I create.
Comment 2 Pierre Rossi 2012-12-05 14:58:06 PST 
Created attachment 177836 [details]
Patch
Comment 3 Pierre Rossi 2012-12-05 15:19:33 PST 
Comment on attachment 177836 [details]
Patch

Simpler patch coming up...
Comment 4 Pierre Rossi 2012-12-05 15:51:59 PST 
Comment on attachment 177836 [details]
Patch

I thought I'd move the call to initializeWebKitWidgets up in QWebPage's constructor, but it's not going to be better in there because of the member initialization, and so it would boil down to the same thing.
We are shooting ourselves in the foot by having QtTestBrowser always discard the first WebPage it constructs, it contributed to keep this silly mistake hidden until we merged it in Qt5... :(
Comment 5 Kenneth Rohde Christiansen 2012-12-05 16:48:29 PST 
Comment on attachment 177836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177836&action=review

> Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:172
> +void QWebPageAdapter::initWebCorePage()

initialize please... consistency
Comment 6 Pierre Rossi 2012-12-06 01:32:56 PST 
Created attachment 177969 [details]
Patch
Comment 7 Simon Hausmann 2012-12-06 05:24:24 PST 
Comment on attachment 177969 [details]
Patch

Oops
Comment 8 WebKit Review Bot 2012-12-06 07:02:25 PST 
Comment on attachment 177969 [details]
Patch

Clearing flags on attachment: 177969

Committed r136842: <http://trac.webkit.org/changeset/136842>
Comment 9 WebKit Review Bot 2012-12-06 07:02:29 PST 
All reviewed patches have been landed.  Closing bug.