WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104131
REGRESSION (
r136683
): css3/calc/background-position-parsing.html failing on EFL Linux 64-bit Debug WK2
https://bugs.webkit.org/show_bug.cgi?id=104131
Summary
REGRESSION (r136683): css3/calc/background-position-parsing.html failing on E...
Thiago Marcos P. Santos
Reported
2012-12-05 09:10:15 PST
Created
attachment 177770
[details]
backtrace css3/calc/background-position-parsing.html started failing on EFL Linux 64-bit Debug WK2 in
r136683
<
http://trac.webkit.org/changeset/136683
>.
http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r136682%20(6697)/results.html
passed
http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r136683%20(6698)/results.html
failed
Attachments
backtrace
(135 bytes, text/plain)
2012-12-05 09:10 PST
,
Thiago Marcos P. Santos
no flags
Details
Patch
(2.38 KB, patch)
2012-12-05 09:39 PST
,
Alexis Menard (darktears)
no flags
Details
Formatted Diff
Diff
Patch
(2.50 KB, patch)
2012-12-05 09:45 PST
,
Alexis Menard (darktears)
no flags
Details
Formatted Diff
Diff
Fix comment
(2.49 KB, patch)
2012-12-05 10:21 PST
,
Alexis Menard (darktears)
no flags
Details
Formatted Diff
Diff
Patch
(4.03 KB, patch)
2012-12-05 12:41 PST
,
Alexis Menard (darktears)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1
2012-12-05 09:23:27 PST
***
Bug 104133
has been marked as a duplicate of this bug. ***
Alexis Menard (darktears)
Comment 2
2012-12-05 09:39:13 PST
Created
attachment 177779
[details]
Patch
Alexis Menard (darktears)
Comment 3
2012-12-05 09:39:44 PST
(In reply to
comment #2
)
> Created an attachment (id=177779) [details] > Patch
I'm wondering if the fix should go in isPositionValue instead. Thoughts?
Alexis Menard (darktears)
Comment 4
2012-12-05 09:45:58 PST
Created
attachment 177782
[details]
Patch
Alexis Menard (darktears)
Comment 5
2012-12-05 10:21:02 PST
Created
attachment 177787
[details]
Fix comment
Anders Carlsson
Comment 6
2012-12-05 12:00:31 PST
Comment on
attachment 177787
[details]
Fix comment View in context:
https://bugs.webkit.org/attachment.cgi?id=177787&action=review
> Source/WebCore/css/CSSParser.cpp:3865 > + m_parsedCalculation.release();
This should be m_parsedCalculation = nullptr;
Antti Koivisto
Comment 7
2012-12-05 12:01:52 PST
Comment on
attachment 177787
[details]
Fix comment View in context:
https://bugs.webkit.org/attachment.cgi?id=177787&action=review
> Source/WebCore/css/CSSParser.cpp:3867 > inline bool CSSParser::isPositionValue(CSSParserValue* value) > { > - return isBackgroundPositionKeyword(value->id) || validUnit(value, FPercent | FLength); > + bool ret = isBackgroundPositionKeyword(value->id) || validUnit(value, FPercent | FLength); > + // validUnit may encounter a CSS calc() and could potentially set m_parsedCalculation to a value. As we may call later isPositionValue again > + // we need to unset it otherwise the next call to validUnit will assert when it will check a calc again. parseFillPositionComponent also workaround this behavior. > + m_parsedCalculation.release(); > + return ret; > }
It seems wrong that a isFoo function has a side effect like this.
Alexis Menard (darktears)
Comment 8
2012-12-05 12:41:42 PST
Created
attachment 177811
[details]
Patch
WebKit Review Bot
Comment 9
2012-12-05 13:39:47 PST
Comment on
attachment 177811
[details]
Patch Clearing flags on attachment: 177811 Committed
r136754
: <
http://trac.webkit.org/changeset/136754
>
WebKit Review Bot
Comment 10
2012-12-05 13:39:51 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug