Bug 104130 - Extra space in fast/css/image-resolution/image-resolution.html
Summary: Extra space in fast/css/image-resolution/image-resolution.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 104132
  Show dependency treegraph
 
Reported: 2012-12-05 09:04 PST by Leo Yang
Modified: 2012-12-05 13:43 PST (History)
3 users (show)

See Also:


Attachments
Patch (42.00 KB, patch)
2012-12-05 09:09 PST, Leo Yang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-12-05 09:04:27 PST
in fast/css/image-resolution/image-resolution.html there is a line like
shouldBe('img.style.cssText', '"image-resolution: ' + test + '; "');

It expect an extra space at the tail of the value of img.style.cssText. But cssText doesn't include the extra space.
Comment 1 Leo Yang 2012-12-05 09:09:16 PST
Created attachment 177769 [details]
Patch
Comment 2 Yong Li 2012-12-05 11:01:39 PST
+David Barr who added this result.

David, any idea?
Comment 3 David Barr 2012-12-05 13:24:36 PST
I believe that cssText included the extra space at the time the test was added.
The was still skipped at the time cssText was updated, and still is.
Hence, whoever fixed cssText would have missed updating this test.
Comment 4 Leo Yang 2012-12-05 13:26:21 PST
OK. Let's go with the patch.
Comment 5 David Barr 2012-12-05 13:41:21 PST
For what it's worth, the change was: http://trac.webkit.org/changeset/126656
CSSStyleDeclaration.cssText should not contain extraneous whitespace in final delimiter (bug 94633)
Comment 6 WebKit Review Bot 2012-12-05 13:42:31 PST
Comment on attachment 177769 [details]
Patch

Clearing flags on attachment: 177769

Committed r136757: <http://trac.webkit.org/changeset/136757>
Comment 7 WebKit Review Bot 2012-12-05 13:42:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Leo Yang 2012-12-05 13:43:21 PST
(In reply to comment #5)
> For what it's worth, the change was: http://trac.webkit.org/changeset/126656
> CSSStyleDeclaration.cssText should not contain extraneous whitespace in final delimiter (bug 94633)

Thanks David.