WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
104130
Extra space in fast/css/image-resolution/image-resolution.html
https://bugs.webkit.org/show_bug.cgi?id=104130
Summary
Extra space in fast/css/image-resolution/image-resolution.html
Leo Yang
Reported
2012-12-05 09:04:27 PST
in fast/css/image-resolution/image-resolution.html there is a line like shouldBe('img.style.cssText', '"image-resolution: ' + test + '; "'); It expect an extra space at the tail of the value of img.style.cssText. But cssText doesn't include the extra space.
Attachments
Patch
(42.00 KB, patch)
2012-12-05 09:09 PST
,
Leo Yang
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Leo Yang
Comment 1
2012-12-05 09:09:16 PST
Created
attachment 177769
[details]
Patch
Yong Li
Comment 2
2012-12-05 11:01:39 PST
+David Barr who added this result. David, any idea?
David Barr
Comment 3
2012-12-05 13:24:36 PST
I believe that cssText included the extra space at the time the test was added. The was still skipped at the time cssText was updated, and still is. Hence, whoever fixed cssText would have missed updating this test.
Leo Yang
Comment 4
2012-12-05 13:26:21 PST
OK. Let's go with the patch.
David Barr
Comment 5
2012-12-05 13:41:21 PST
For what it's worth, the change was:
http://trac.webkit.org/changeset/126656
CSSStyleDeclaration.cssText should not contain extraneous whitespace in final delimiter (
bug 94633
)
WebKit Review Bot
Comment 6
2012-12-05 13:42:31 PST
Comment on
attachment 177769
[details]
Patch Clearing flags on attachment: 177769 Committed
r136757
: <
http://trac.webkit.org/changeset/136757
>
WebKit Review Bot
Comment 7
2012-12-05 13:42:35 PST
All reviewed patches have been landed. Closing bug.
Leo Yang
Comment 8
2012-12-05 13:43:21 PST
(In reply to
comment #5
)
> For what it's worth, the change was:
http://trac.webkit.org/changeset/126656
> CSSStyleDeclaration.cssText should not contain extraneous whitespace in final delimiter (
bug 94633
)
Thanks David.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug