Bug 104128 – Coordinated Graphics: Enable support for setContentsToBackgroundColor

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Noam Rosenthal]

Coordinated Graphics: Enable support for setContentsToBackgroundColor

[Noam Rosenthal]

Created attachment 177765 [details]
Patch

[Noam Rosenthal]

This would enable us to support direct compositing of background colors, see 103786.

[Kenneth Rohde Christiansen]

Comment on attachment 177765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177765&action=review

> Source/WebKit2/ChangeLog:9
> +
> +        Enable setContentsToBackgroundColor in CoordinatedGraphicsLayer, and pass it through to the UI process.
> +

Better explain what it actually means, what it is used for

> Source/WebKit2/ChangeLog:35
> +        (WebCore::CoordinatedGraphicsLayer::setContentsToBackgroundColor):
> +        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
> +        (CoordinatedGraphicsLayer):
> +
> [phone]  No'am Rosenthal  <[e-mail]>
> +
> +        Use background color for GraphicsLayers when applicable
> +        https://bugs.webkit.org/show_bug.cgi?id=103786
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Enable setContentsToBackgroundColor for coordinated graphics.
> +
> +        * Shared/WebLayerTreeInfo.h:
> +        (WebLayerInfo):
> +        * UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
> +        (WebKit::LayerTreeRenderer::setLayerState):
> +        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
> +        (WebCore::CoordinatedGraphicsLayer::setContentsToBackgroundColor):
> +        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
> +        (CoordinatedGraphicsLayer):

why two change log entries?

[Noam Rosenthal]

Created attachment 177778 [details]
Patch

[Noam Rosenthal]

Created attachment 177857 [details]
Patch

[Noam Rosenthal]

Comment on attachment 177857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177857&action=review

> LayoutTests/compositing/overflow/resize-painting-expected.txt:-10
> -          (drawsContent 1)

This layer actually doesn't draw content; I'm not sure why the expected results have a drawsContent flag.

[Noam Rosenthal]

Comment on attachment 177857 [details]
Patch

Oops, wrong patch.

[Noam Rosenthal]

Created attachment 177870 [details]
Patch

[WebKit Review Bot]

Comment on attachment 177870 [details]
Patch

Clearing flags on attachment: 177870

Committed r136781: <http://trac.webkit.org/changeset/136781>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.