Bug 104126 - Stop generating call stacks inside ContentSecurityPolicy
Summary: Stop generating call stacks inside ContentSecurityPolicy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-05 08:08 PST by Mike West
Modified: 2012-12-05 11:19 PST (History)
5 users (show)

See Also:


Attachments
Patch (33.11 KB, patch)
2012-12-05 08:31 PST, Mike West
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2012-12-05 08:08:30 PST
Now that bug 100650 landed, we can stop generating calls stacks inside ContentSecurityPolicy::logToConsole.

This will require piping the ScriptState down into Inspector, but also means that we can slightly simplify the external addConsoleMessage interface.

I'll do my best to make this patch simpler to review than that one was. :)
Comment 1 Mike West 2012-12-05 08:31:40 PST
Created attachment 177759 [details]
Patch
Comment 2 Mike West 2012-12-05 11:01:27 PST
Comment on attachment 177759 [details]
Patch

Thanks Yury. Sorry if I'm burying you in patches these days. :)
Comment 3 WebKit Review Bot 2012-12-05 11:19:08 PST
Comment on attachment 177759 [details]
Patch

Clearing flags on attachment: 177759

Committed r136719: <http://trac.webkit.org/changeset/136719>
Comment 4 WebKit Review Bot 2012-12-05 11:19:12 PST
All reviewed patches have been landed.  Closing bug.